-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate project from OXC to SWC, add generic helper functions, and update dependencies #10
Conversation
One small change requested then will merge. @shahryarjb how do you run the tests in the rust file? We should add that to CI. |
Dear @zachdaniel for testing First I run this command to fix all warnings (It suggests to edit code, not about working or not)
After that I run it for testing
|
🚀 Thank you for your contribution! 🚀 |
@shahryarjb thank you, could you open an issue suggesting to run those two commands? I'm assuming clippy can be made to fail if it has any suggestions. |
Based on the issue we encountered with removing comments during the editing of JavaScript files using OXC, I have fully migrated the project to SWC.
In this pull request, several key functions have been modified, and it’s necessary to update code written with the old structure accordingly.
I’ve also added some generic helper functions in Rust, and moving forward, we might encounter more errors related to parsing invalid JavaScript files.
Additionally, dependencies related to Rustler have been updated, both on the Elixir and Rust sides.
Close #8