Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate project from OXC to SWC, add generic helper functions, and update dependencies #10

Merged
merged 9 commits into from
Jan 16, 2025

Conversation

shahryarjb
Copy link
Collaborator

Based on the issue we encountered with removing comments during the editing of JavaScript files using OXC, I have fully migrated the project to SWC.

In this pull request, several key functions have been modified, and it’s necessary to update code written with the old structure accordingly.

I’ve also added some generic helper functions in Rust, and moving forward, we might encounter more errors related to parsing invalid JavaScript files.

Additionally, dependencies related to Rustler have been updated, both on the Elixir and Rust sides.

Close #8

@shahryarjb shahryarjb added bug Something isn't working enhancement New feature or request dependencies Pull requests that update a dependency file labels Jan 15, 2025
@shahryarjb shahryarjb requested a review from zachdaniel January 15, 2025 06:59
@shahryarjb shahryarjb self-assigned this Jan 15, 2025
@zachdaniel
Copy link
Contributor

One small change requested then will merge. @shahryarjb how do you run the tests in the rust file? We should add that to CI.

@shahryarjb
Copy link
Collaborator Author

One small change requested then will merge. @shahryarjb how do you run the tests in the rust file? We should add that to CI.

Dear @zachdaniel for testing

First I run this command to fix all warnings (It suggests to edit code, not about working or not)

cargo clippy

After that I run it for testing

cargo test

@zachdaniel zachdaniel merged commit 668fab7 into ash-project:main Jan 16, 2025
15 checks passed
@zachdaniel
Copy link
Contributor

🚀 Thank you for your contribution! 🚀

@zachdaniel
Copy link
Contributor

@shahryarjb thank you, could you open an issue suggesting to run those two commands? I'm assuming clippy can be made to fail if it has any suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent Deleting Comments from JavaScript Code
2 participants