resolves #19 - migrate to Foundation 5 #23
Conversation
mojavelinux
commented
Jan 5, 2015
mojavelinux
commented
- migrate from Foundation 4 to Foundation 5
- upgrade to Compass 1.0.1
- make stylesheet changes necessary to accomodate upgrades
- add Bower configuration
- update README with information about Bower requirement
- refactor handling of trailing margins in asciidoc component
- drop old themes: iconic, colony, maker, rubygems
- rework readthedocs theme to match new theme on readthedocs.org
- add motion theme
- improve build-stylesheet.sh script
- declare custom sass functions
- fix background colors for sidebar & example blocks in asciidoctor theme
- many minor refinements to styles & scss source
mojavelinux
force-pushed
the
foundation-5-upgrade
branch
from
738c3e0
to
c511117
Compare
mojavelinux
changed the title
mojavelinux
force-pushed
the
foundation-5-upgrade
branch
from
c511117
to
62d010e
Compare
mojavelinux
force-pushed
the
foundation-5-upgrade
branch
4 times, most recently
from
84b9a09
to
984b161
Compare
- migrate from Foundation 4 to Foundation 5 - upgrade to Compass 1.0.1 - make stylesheet changes necessary to accomodate upgrades - add Bower configuration - update README with information about Bower requirement - refactor handling of trailing margins in asciidoc component - drop old themes: iconic, colony, maker, rubygems - rework readthedocs theme to match new theme on readthedocs.org - add motion theme - improve build-stylesheet.sh script - declare custom sass functions - fix background colors for sidebar & example blocks in asciidoctor theme - many minor refinements to styles & scss source
mojavelinux
force-pushed
the
foundation-5-upgrade
branch
from
984b161
to
64cfed3
Compare
|
I will do a code review this week-end 😄 |
|
👍 |
|
https://github.com/Huddle/PhantomCSS is looking great, I will try to setup a simple script to automate visual testing. |
|
I'd be happy to pick up the PhantomCSS testing. Could you give me some pointers on where to put the automated visual testing? It would be nice to push onto Foundation 6, but there isn't a migration guide that I've seen. I'd be happy to dig in. I have got asciidoctor to compile with libsass (via node-sass and bower) which means that Ruby can go altogether. This might be something to explore, as libsass is more portable than compass/ruby. I used a compass-mixin library from bower. |
|
Hello @SevereOverfl0w
I've done some work with PhantomCSS here: #30 During my tests, I've only found one small "regression", so I think it's safe to merge this pull request and work on the next migration (Foundation 5 > Foundation 6). Otherwise we will fall behind quickly 😢 |
