Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asciidoctor compact theme and build script change #11

Closed
wants to merge 11 commits into from

Conversation

nerk
Copy link
Member

@nerk nerk commented May 29, 2014

This adds a compact version of the default Asciidoctor theme, 'asciidoctor-compact'. Smaller font and less spacing between elements.

The build script failed when invoked directly, because it used 'let' which is not known to '/bin/sh'.

@leif81
Copy link
Member

leif81 commented Jul 13, 2014

👍 I'm a fan of the compact theme idea. I've used it in Brackets. This compact theme has got me especially excited thinking about combining this with PR #12 and #13 that make printing asciidoctor HTML more compelling. A shorter print version is a nice theme to have available.

A couple things:

  • The print styles, @import "components/print"; should probably be added to asciidoctor-compact.scss?
  • The font size in the #preamble > .paragraph seems large and may have been overlooked (noticeable in asciidoctor-writers-guide.adoc). Not sure if this was deliberate or not.

@mojavelinux
Copy link
Member

I'll be looking at this pull request during or shortly after getting 1.5.0 released.

@nerk
Copy link
Member Author

nerk commented Aug 3, 2014

Leif, thanks for your comments. I applied the changes you suggested to the asciidoctor-compact theme. It's already part of the Brackets extension. I'll update the official Brackets plugin repository once the final 1.5 release of Asciidoctor is out.

@mojavelinux
Copy link
Member

Now that 1.5.0 is out, I'll be sure to look into getting this merged soon. Great stuff!

@nerk
Copy link
Member Author

nerk commented Aug 17, 2014

This is outdated as of 1.5.0. Just grab https://github.com/nerk/asciidoctor-stylesheet-factory/blob/master/sass/asciidoctor-compact.scss for an updated version. Currently, this is good enough for me for the brackets preview, but is a bit of a quick hack and could certainly use some tuning.

Maybe some SASS control directives should be put into original asciidoctor.scss to allow for creating the original and compact styles from the same source?

@nerk
Copy link
Member Author

nerk commented Aug 17, 2014

@mojavelinux
Copy link
Member

I agree, compact should probably be a variation on the default theme so they stay in sync.

@testn
Copy link

testn commented Jun 22, 2015

@nerk , any chance to get this one merged?

@mojavelinux
Copy link
Member

I'm still holding on this one because of the refactoring mentioned in #2 and #23. However, I could take a look and see if I can merge it before then so it isn't necessary to wait. My attention has just been elsewhere in Asciidoctor recently (mostly PDF).

@nerk
Copy link
Member Author

nerk commented Jun 23, 2015

Unfortunately, I do not have enough skills regarding typography to make the compact style really good. @mojavelinux would certainly be the right person. The current stylesheet was more of a hack to make something work for the Brackets preview.

@nerk
Copy link
Member Author

nerk commented Dec 16, 2016

This is completely outdated. In addition, the compact theme needs a lot of work before it is ready.

@nerk nerk closed this Dec 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants