Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Diacritics strings translatable. (1803) #1809

Closed
wants to merge 1 commit into from
Closed

Make Diacritics strings translatable. (1803) #1809

wants to merge 1 commit into from

Conversation

melaniekung
Copy link
Contributor

No description provided.

@melaniekung melaniekung added Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. labels May 7, 2024
@melaniekung melaniekung requested a review from a team May 7, 2024 05:00
@melaniekung melaniekung self-assigned this May 7, 2024
@melaniekung melaniekung linked an issue May 7, 2024 that may be closed by this pull request
Problem: Some strings are missing in the translations bar from the new Diacritics settings page #1803
Open
jraddaoui
jraddaoui reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from indentation, are there any functional changes in this PR @mel?

@melaniekung
Copy link
Contributor Author

@jraddaoui no, but the identations were required to make that string translatable

@jraddaoui
Copy link
Contributor

@melaniekung, do you know why? It's the first time I see this.

@melaniekung
Copy link
Contributor Author

@jraddaoui, i'm sorry i didn't catch this earlier... i don't think there's an issue with the original code - if we log into translations repo, we can see that the string is present and ready for translations. the issue mentioned using the translations bar menu where the string is not present for translations. my PR included the wrong wording for the reindex msg (copied code from languages settings page, which was already a translated string in AtoM.

not sure if there's still an issue present on figuring out why that string isn't present in the translations bar menu?

@melaniekung melaniekung closed this May 9, 2024
@melaniekung melaniekung deleted the dev/1803-diacritics-translations branch May 9, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jraddaoui jraddaoui jraddaoui left review comments

Assignees

@melaniekung melaniekung

Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: Some strings are missing in the translations bar from the new Diacritics settings page
2 participants
@melaniekung @jraddaoui