Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Some strings are missing in the translations bar from the new Diacritics settings page #1803

Open
fiver-watson opened this issue Apr 24, 2024 · 0 comments
Open

Problem: Some strings are missing in the translations bar from the new Diacritics settings page #1803

fiver-watson opened this issue Apr 24, 2024 · 0 comments
Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.

Comments

@fiver-watson
Copy link
Contributor

fiver-watson commented Apr 24, 2024 •
edited by melaniekung
Loading

Current Behavior

First reported via the user forum, 2024-04-24

Steps to reproduce the behavior

  • Log into a 2.8.x AtoM instance as an administrator
  • Navigate to Admin > Settings > Diacritics
  • Using the Language menu, flip the user interface settings to another langauge (e.g. French)
  • Open the Translation bar menu
  • Review the elements on the page that are still in English / untranslated, and look for them in the Translation bar menu

Error encountered

A number of strings on the page do not appear to be translatable at the moment, such as:

  • The maximum size of file uploads is 64 MB.
  • Please rebuild the search index after uploading diacritics mappings.
  • Choose File and No file chosen

Expected Behavior

All text strings should be available for translation in the translations bar

Context and Notes

The string is present in the translations repo, but not seen in the built-in translations bar of AtoM GUI.

Version used

qa/2.x Docker instance - AtoM settings page reads: 2.8.2 - 193

Operating System and version

Ubuntu 20.04

Default installation culture

en

PHP version

PHP 7.4

Contact details

No response
@fiver-watson fiver-watson added Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result. good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. labels Apr 24, 2024
@melaniekung melaniekung linked a pull request May 7, 2024 that will close this issue
Make Diacritics strings translatable. (1803) #1809
Closed
@melaniekung melaniekung changed the title Problem: Some strings cannot be translated on new Diacritics settings page Problem: Some strings cannot be translated through the translations bar on new Diacritics settings page May 9, 2024
@melaniekung melaniekung changed the title Problem: Some strings cannot be translated through the translations bar on new Diacritics settings page Problem: Some strings are missing in the translations bar from the new Diacritics settings page May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue An issue that would be easy for someone who has not worked with the codebase/docs before. Type: bug A flaw in the code that causes the software to produce an incorrect or unexpected result.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Diacritics strings translatable. (1803) artefactual/atom
1 participant
@fiver-watson