Enable tracing in http.Client #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sevein
force-pushed
the
dev/http-client-tracing
branch
from
07e56b6 to
17e0cbc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #896 +/- ##
==========================================
+ Coverage 47.11% 47.24% +0.13%
==========================================
Files 96 95 -1
Lines 5383 5224 -159
==========================================
- Hits 2536 2468 -68
+ Misses 2611 2522 -89
+ Partials 236 234 -2 ☔ View full report in Codecov by Sentry. |
sevein
force-pushed
the
dev/http-client-tracing
branch
3 times, most recently
from
1594992 to
4c5749c
Compare
djjuhasz
approved these changes
Mar 28, 2024
Register a propagator with OpenTelemetry to enable propagation of trace context over the wire. Update HTTP clients with `otelhttp.Transport` to wrap outbound requests with a span and enrich it with metrics. This change enable us to relate spans occuring beyond an individual service, e.g. the activity "move-to-permanent-storage" executed by enduro-a3m-worker uses a HTTP client to request to the Storage Service the long-term storage of the AIP. With this commit we'll start seeing the `HTTP POST` operation performed by the client but also the rest of the details happening on the server side (child spans), e.g.: API handler, SQL queries, workflow, activities, functions...
This function could be more efficient if we introduced insert batches. This
commit should make that more apparent, e.g. will read something like:
savePreservationTasks (703.14ms)
Which is only part of the time that took the entire activity to run, e.g. 5.33s
in my development environment.
I'm still trying to figure out what's the best way to share tracers. The SDK encourages to operate with globals but for consistency I'm trying to share them just like we share other values, e.g. context, logger, etc. [skip codecov]
sevein
force-pushed
the
dev/http-client-tracing
branch
from
4c5749c to
8e081c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register a propagator with OpenTelemetry to enable propagation of trace context over the wire 1. Update HTTP clients with
otelhttp.Transportto wrap outbound requests with a span and enrich it with metrics.This change enable us to relate spans occuring beyond an individual service, e.g. the activity "move-to-permanent-storage" executed by enduro-a3m-worker uses a HTTP client to request to the Storage Service the long-term storage of the AIP. With this commit we'll start seeing the
HTTP POSToperation performed by the client but also the rest of the details happening on the server side, i.e. the API handler, SQL queries, workflow, activities, etc.Footnotes
See the Trace Context spec (W3C Recommendation) for more details. It defines HTTP headers and a value format to standardize how context information is propagated over the wire. ↩