Pass tracer as a function parameter

I'm still trying to figure out what's the best way to share tracers. The SDK
encourages to operate with globals but for consistency I'm trying to share them
just like we share other values, e.g. context, logger, etc.

[skip codecov]

cmd/enduro-a3m-worker/main.go

@@ -188,7 +188,7 @@ func main() {
 		}
 
 		w.RegisterActivityWithOptions(
-			activities.NewDownloadActivity(logger, wsvc).Execute,
+			activities.NewDownloadActivity(logger, tp.Tracer(activities.DownloadActivityName), wsvc).Execute,
 			temporalsdk_activity.RegisterOptions{Name: activities.DownloadActivityName},
 		)
 		w.RegisterActivityWithOptions(

cmd/enduro-am-worker/main.go

@@ -201,7 +201,7 @@ func main() {
 		sftpClient := sftp.NewGoClient(logger, cfg.AM.SFTP)
 
 		w.RegisterActivityWithOptions(
-			activities.NewDownloadActivity(logger, wsvc).Execute,
+			activities.NewDownloadActivity(logger, tp.Tracer(activities.DownloadActivityName), wsvc).Execute,
 			temporalsdk_activity.RegisterOptions{Name: activities.DownloadActivityName},
 		)
 		w.RegisterActivityWithOptions(

internal/workflow/activities/download.go

@@ -10,12 +10,14 @@ import (
 	temporal_tools "go.artefactual.dev/tools/temporal"
 	"go.opentelemetry.io/otel/trace"
 
+	"github.com/artefactual-sdps/enduro/internal/telemetry"
 	"github.com/artefactual-sdps/enduro/internal/watcher"
 )
 
 // DownloadActivity downloads the blob into the processing directory.
 type DownloadActivity struct {
 	logger logr.Logger
+	tracer trace.Tracer
 	wsvc   watcher.Service
 }
 
@@ -28,9 +30,10 @@ type DownloadActivityResult struct {
 	Path string
 }
 
-func NewDownloadActivity(logger logr.Logger, wsvc watcher.Service) *DownloadActivity {
+func NewDownloadActivity(logger logr.Logger, tracer trace.Tracer, wsvc watcher.Service) *DownloadActivity {
 	return &DownloadActivity{
 		logger: logger,
+		tracer: tracer,
 		wsvc:   wsvc,
 	}
 }
@@ -51,11 +54,9 @@ func (a *DownloadActivity) Execute(
 
 	dest := filepath.Clean(filepath.Join(destDir, params.Key))
 
-	ctx, span := trace.SpanFromContext(ctx).TracerProvider().Tracer(DownloadActivityName).Start(ctx, "download")
+	ctx, span := a.tracer.Start(ctx, "download")
 	if err := a.wsvc.Download(ctx, dest, params.WatcherName, params.Key); err != nil {
-
-		span.RecordError(err)
-		span.End()
+		telemetry.RecordError(span, err)
 		return &DownloadActivityResult{}, temporal_tools.NewNonRetryableError(fmt.Errorf("download: %v", err))
 	}
 	span.End()

internal/workflow/processing_test.go

@@ -10,6 +10,7 @@ import (
 	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/suite"
 	"go.artefactual.dev/amclient/amclienttest"
+	"go.opentelemetry.io/otel/trace/noop"
 	temporalsdk_activity "go.temporal.io/sdk/activity"
 	temporalsdk_testsuite "go.temporal.io/sdk/testsuite"
 	temporalsdk_worker "go.temporal.io/sdk/worker"
@@ -74,7 +75,7 @@ func (s *ProcessingWorkflowTestSuite) SetupWorkflowTest(taskQueue string) {
 	sftpc := sftp_fake.NewMockClient(ctrl)
 
 	s.env.RegisterActivityWithOptions(
-		activities.NewDownloadActivity(logger, wsvc).Execute,
+		activities.NewDownloadActivity(logger, noop.Tracer{}, wsvc).Execute,
 		temporalsdk_activity.RegisterOptions{Name: activities.DownloadActivityName},
 	)
 	s.env.RegisterActivityWithOptions(
@@ -86,7 +87,7 @@ func (s *ProcessingWorkflowTestSuite) SetupWorkflowTest(taskQueue string) {
 		temporalsdk_activity.RegisterOptions{Name: activities.BundleActivityName},
 	)
 	s.env.RegisterActivityWithOptions(
-		a3m.NewCreateAIPActivity(logger, &a3m.Config{}, pkgsvc).Execute,
+		a3m.NewCreateAIPActivity(logger, noop.Tracer{}, &a3m.Config{}, pkgsvc).Execute,
 		temporalsdk_activity.RegisterOptions{Name: a3m.CreateAIPActivityName},
 	)
 	s.env.RegisterActivityWithOptions(