Avoid deeply nested LinearCombination
s in EvaluationsVar::interpolate_and_evaluate
#145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is observed in privacy-scaling-explorations/sonobe#80 that stack overflow occurs when calling$n > 11$ ).
EvaluationsVar::interpolate_and_evaluate
for large evaluation domains (e.g., whenI think this happens because in
EvaluationsVar::lagrange_interpolate_with_constant_offset
andEvaluationsVar::lagrange_interpolate_with_non_constant_offset
, we are updating the final evaluation result in a for loop, and+=
in each iteration wraps the current result by a new layer ofLinearCombination
. This produces a deeply nestedLinearCombination
. When we get.value()
of the evaluation result, internallyConstraintSystem::assigned_value
is invoked to recursively flatten the LC. Unfortunately, the number of LC layers of the evaluation result is so large that the recursion depth exceeds the OS limit, resulting in a stack overflow.This PR fixes the above bug by calling
.sum()
on the iterator of addends, since this method invokesAllocatedFp::add_many
, which produces a flat LC.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer