Resolve the stack overflow issue when evaluating polynomials in-circuit #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaucube
approved these changes
Oct 3, 2024
Merged
via the queue into
privacy-scaling-explorations:main
with commit Oct 3, 2024
ed14889
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uncomments the code for evaluating polynomials in-circuit, because the stack overflow issue was already addressed in arkworks-rs/r1cs-std#145. There was another issue in
r1cs-stdthat caused panics during polynomial interpolation, which is now fixed in winderica/r1cs-std@7060222 (corresponding PR: arkworks-rs/r1cs-std#148).Closes #80 and #130.