-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common Packet のデフォルト実装を core から提供する(Space Packet のみ) #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
changed the title
WIP:
Common Packet のデフォルト実装を core から提供する(Space Packet のみ)
Apr 3, 2024
meltingrabbit
added
enhancement
New feature or request
priority::high
priorityg high
labels
Apr 3, 2024
meltingrabbit
commented
Apr 3, 2024
@sksat さっき話した修正を施しました.レビューお願いします.
|
sksat
requested changes
Apr 4, 2024
meltingrabbit
force-pushed
the
feature/add_sp_defalt_impl
branch
from
April 5, 2024 09:46
ebccc98
to
6261bc6
Compare
sksat
requested changes
Apr 8, 2024
examples/mobc/src/src_user/settings/tlm_cmd/common_tlm_packet_define.c
Outdated
Show resolved
Hide resolved
sksat
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
C2A_USE_SPACE_PACKET_AS_COMMON_PACKET
を追加している.C2A_MOBC_FEATURES
オプションによってスイッチさせているCTP_set_on_board_subnet_time
のみ異なるsrc/src_user/settings/tlm_cmd/common_tlm_packet_define.c
に定義をする必要がある.(CTP のうち,CTP_set_global_time
のみこのファイルに分離した)Issue
検証結果
CI がとおればOK
影響範囲
User に含まれる以下のファイルが不要になる
また,
CTP_set_global_time
を定義することが必須となり,などを新規に作成する必要がある.
examples/subobc/src/src_user/settings/tlm_cmd/common_tlm_packet_define.c
に例を配置した.