-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route53 #25
base: master
Are you sure you want to change the base?
Route53 #25
Conversation
…he Response Additionally remove an outdated TODO
…eId, ChangeId, and Domain
--HG-- rename : Examples/Route53Examples.hs => Examples/Route53/Utils.hs
--HG-- rename : Examples/Route53/DynDNS.hs => Examples/Route53/R53DynDNS.hs
--HG-- rename : Examples/Route53/R53DynDNS.hs => Examples/Route53/r53-dyndns.hs
The fix includes porting all functions that returned IO (Attempt a) to return MonadIO m => AttemptT m a.
Is there a plan for a release on hackage that supports Route 53? Thanks! |
@jberryman There are a couple of things with this pull request that would need to be sorted out, so I don't think this can happen too soon. The main problem right now, I think, is that this pull request introduces some additional dependencies which I don't want to put into the aws main package. |
Hi, Unfortunately I currently have no free cycles to work on the Route53 code Alternatively, the Route53 code could be put into Hackage as a separate Cheers, From: Aristid Breitkreuz [email protected] @jberryman https://github.com/jberryman There are a couple of things with The main problem right now, I think, is that this pull request introduces ‹ |
FWIW as a user I wouldn't mind seeing the package split up into many parts,
|
Has there been any update on this? |
@dterei I have pushed a version that merges these changes and builds on the most recent version in our repo (https://github.com/alphaHeavy/aws/tree/Route53-test). I may work on breaking the xml-hamlet dependency. |
Hi Steve, Thanks for updating the code. Would it be possible do the merge such Thanks, On 7/18/13 9:33 PM, Steve Severance wrote:
|
@aristidb Could you list what you'd like changed for this to be merged in please? Is it simply removing the xml-hamlet dependency or is there more? |
Well that's what I noticed first, I'd need to take a closer look to list
|
For anyone looking for this code, we created an independent route53 package from this PR a while back and actively maintain it as we rely on it in production. It's essentially the code from this PR with some bug fixes and kept up-to-date for latest GHC / Hackage. |
Hi Aristid,
Please consider merging the Route53 branch into the master branch. I would recommend that you have a quick lock at the Route53 code in order to ensure that it meats the quality bar and the coding style of the project.
Thanks,
Lars