feat: Branding #18717

jsartisan · 2022-12-06T07:50:53Z

Allow super admin to set favicon, logo, and primary color according to their brand for their instance.

updates the look and feel of login/signup pages.
consumes the values of colors on all CTA
updates the look and feel of errors pages ( 404, 502, 503, etc )
![image](https://user-images.githubusercontent.com/6636360/206670380-8fa0fd32-1962-4d09-a4b9-3d264c667c6f.png

Fixes #16217
Fixes #16216
Fixes #16215
Fixes #16214
Fixes #16213

Type of change

New feature

How Has This Been Tested?

Manually
With Cypress

Checklist:

Dev activity

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
PR is being merged under a feature flag

QA activity:

Test plan has been approved by relevant developers
Test plan has been peer reviewed by QA
Cypress test cases have been added and approved by either SDET or manual QA
Organized project review call with relevant stakeholders after Round 1/2 of QA
Added Test Plan Approved label after reveiwing all Cypress test

vercel · 2022-12-06T07:50:57Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
appsmith	⬜️ Ignored (Inspect)		Dec 9, 2022 at 11:54AM (UTC)

github-actions · 2022-12-06T07:51:39Z

Unable to find test scripts. Please add necessary tests to the PR.

Signed-off-by: Shrikant Sharat Kandula <[email protected]>

ankitakinger · 2022-12-08T03:56:11Z

app/client/src/ce/sagas/SuperUserSagas.tsx

-        type: ReduxActionTypes.RESTART_SERVER_POLL,
-      });
+
+      if (needsRestart) {


I think the variable name here isn't correct. If I'm not wrong, branding changes after saving don't need a server restart, correct? While other settings need.

Oopps. My bad. Let me fix it. I goofed while copying code from EE repo.

ankitakinger · 2022-12-08T03:57:14Z

app/client/src/components/propertyControls/ColorPickerComponentV2.tsx

@@ -26,6 +26,7 @@ import { extractColorsFromString } from "utils/helpers";
 import { TAILWIND_COLORS } from "constants/ThemeConstants";
 import useDSEvent from "utils/hooks/useDSEvent";
 import { DSEventTypes } from "utils/AppsmithUtils";
+import { getTenantConfig } from "ce/selectors/tenantSelectors";


update the import to use @appsmith

ankitakinger · 2022-12-08T04:00:30Z

app/client/src/pages/Settings/FormGroup/ColorInput.tsx

+  border: red;
+  z-index: 1;
+  display: flex;
+  border: 1px solid #e0dede;


we can use CSS variables for color here.

ankitakinger · 2022-12-08T04:18:09Z

app/client/src/pages/common/PageHeader.tsx

@@ -26,36 +25,23 @@ import MobileSideBar from "./MobileSidebar";
 import { Indices } from "constants/Layers";
 import { Icon, IconSize } from "design-system";
 import { getTemplateNotificationSeenAction } from "actions/templateActions";
+import { getTenantConfig } from "ce/selectors/tenantSelectors";


use @appsmith here as well in the import

ankitakinger · 2022-12-08T04:20:56Z

app/client/src/utils/BrandingUtils.ts

+  const image = new Image();
+  image.src = window.URL.createObjectURL(file);
+
+  image.onload = function() {


This file name is .tsx in EE PR. Just giving heads up you will face merge-conflict later in EE.

It's okay. I'll use .ts only. .tsx was wrong before

ankitakinger · 2022-12-08T04:22:21Z

app/client/yarn.lock

-  version "1.0.34"
-  resolved "https://registry.yarnpkg.com/@appsmithorg/design-system/-/design-system-1.0.34.tgz#ebf63414bec56fecb5c1d5c3464aee91363a151b"
-  integrity sha512-4epvp8Q2X3mH2UV/yvEzdCCrDPiayV2WKR6t6zS5N6O46DIqQfAVbKqANNqEFlMcZMMmzvr6MEBV6PS0arK1yw==
+"design-system@npm:@appsmithorg/[email protected]":


I think in package.json the version is 37-alpha.7 which doesn't match the version in this file.

I'll be using a stable version once i get a sign off from review and qa.

ankitakinger

Since you have changed the path for favicon-orange.ico, please update the path in manifest.json file as well. Also, if it is used in any other files, then those too.
Should we add messages to img alt all over in the new pages you created?

Everything else looks good to me.

ankitakinger · 2022-12-08T05:15:28Z

app/client/public/manifest.json

@@ -3,7 +3,7 @@
  "name": "Appsmith Client Web UI",
  "icons": [
    {
-      "src": "favicon-orange.ico",
+      "src": "/static/img/favicon-orange.ico",


I'm not sure but I think the first / is not required. Have you checked this out locally?

ankitakinger

LGTM

Aishwarya-U-R · 2022-12-09T06:02:12Z

/ok-to-test sha=70c3a3a

github-actions · 2022-12-09T06:02:40Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3654910427.
Workflow: Appsmith External Integration Test Workflow.
Commit: 70c3a3a.
PR: 18717.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18717&runId=3654910427_1

…feat/branding

jsartisan · 2022-12-09T08:40:04Z

/ok-to-test sha=0f715a4

github-actions · 2022-12-09T08:40:29Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3655808055.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0f715a4.
PR: 18717.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18717&runId=3655808055_1

… into feat/branding

…randing

…feat/branding

jsartisan · 2022-12-09T12:03:37Z

/ok-to-test sha=fe06121

github-actions · 2022-12-09T12:03:59Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3657169089.
Workflow: Appsmith External Integration Test Workflow.
Commit: fe06121.
PR: 18717.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=18717&runId=3657169089_1

coderabbitai · 2024-08-06T07:48:07Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

24 files out of 81 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

add branding for ce

a9d98d4

github-actions bot added the Enhancement New feature or request label Dec 6, 2022

add ce changes

fec448d

vercel bot deployed to Preview – appsmith December 7, 2022 10:10 View deployment

update colorpicker ux

a47c2fa

vercel bot deployed to Preview – appsmith December 7, 2022 10:42 View deployment

remove unsued flag

b63738d

vercel bot deployed to Preview – appsmith December 7, 2022 10:44 View deployment

jsartisan requested a review from ankitakinger December 7, 2022 12:27

sharat87 and others added 2 commits December 7, 2022 18:12

Add new email templates

b28e0d7

Signed-off-by: Shrikant Sharat Kandula <[email protected]>

add local appsmith logo

689f8df

vercel bot deployed to Preview – appsmith December 8, 2022 03:24 View deployment

ankitakinger reviewed Dec 8, 2022

View reviewed changes

code review feedback fixes + qa fixes

a4edcec

ankitakinger reviewed Dec 8, 2022

View reviewed changes

vercel bot deployed to Preview – appsmith December 8, 2022 04:22 View deployment

ankitakinger reviewed Dec 8, 2022

View reviewed changes

latest pull + review feedback fixes

a64439e

vercel bot deployed to Preview – appsmith December 8, 2022 05:12 View deployment

ankitakinger reviewed Dec 8, 2022

View reviewed changes

remove forward slash in url of favicon

6a7ee00

ankitakinger previously approved these changes Dec 8, 2022

View reviewed changes

vercel bot deployed to Preview – appsmith December 8, 2022 05:27 View deployment

fix message

f547139

Merge branch 'release' into feat/branding

70c3a3a

vercel bot deployed to Preview December 9, 2022 06:08 View deployment

Aishwarya-U-R and others added 3 commits December 9, 2022 13:53

Merge branch 'release' into feat/branding

2a12ee9

try moving test

33b4555

Merge branch 'feat/branding' of github.com:appsmithorg/appsmith into …

0f715a4

…feat/branding

vercel bot deployed to Preview December 9, 2022 08:45 View deployment

mohanarpit mentioned this pull request Dec 9, 2022

feat: New email templates #18754

Closed

use stable DS version

d9ed116

github-actions bot added Widgets Product This label groups issues related to widgets Branding Product All issues under branding and whitelabelling appsmith ecosystem potential-duplicate This label marks issues that are potential duplicates of already open issues labels Dec 9, 2022

vercel bot deployed to Preview December 9, 2022 09:42 View deployment

remove __diff

53ada64

vercel bot deployed to Preview December 9, 2022 09:53 View deployment

Merge branch 'feat/branding' of https://github.com/appsmithorg/appsmith…

db4939e

… into feat/branding

vercel bot deployed to Preview December 9, 2022 10:15 View deployment

jsartisan added 2 commits December 9, 2022 17:23

Merge branch 'release' of github.com:appsmithorg/appsmith into feat/b…

5c580df

…randing

Merge branch 'feat/branding' of github.com:appsmithorg/appsmith into …

fe06121

…feat/branding

ankitakinger approved these changes Dec 9, 2022

View reviewed changes

jsartisan merged commit d7e2c49 into release Dec 9, 2022

jsartisan deleted the feat/branding branch December 9, 2022 14:43

Nikhil-Nandagopal added Platform Administration Pod Issues related to platform administration & management and removed Widgets Product This label groups issues related to widgets labels Aug 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Branding #18717

feat: Branding #18717

jsartisan commented Dec 6, 2022 •

edited

Loading

vercel bot commented Dec 6, 2022 •

edited

Loading

github-actions bot commented Dec 6, 2022

ankitakinger Dec 8, 2022

jsartisan Dec 8, 2022

ankitakinger Dec 8, 2022

ankitakinger Dec 8, 2022

ankitakinger Dec 8, 2022

ankitakinger Dec 8, 2022

jsartisan Dec 8, 2022

ankitakinger Dec 8, 2022

jsartisan Dec 8, 2022

ankitakinger left a comment

ankitakinger Dec 8, 2022

ankitakinger left a comment

Aishwarya-U-R commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

jsartisan commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

jsartisan commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

coderabbitai bot commented Aug 6, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

feat: Branding #18717

feat: Branding #18717

Conversation

jsartisan commented Dec 6, 2022 • edited Loading

Type of change

How Has This Been Tested?

Checklist:

Dev activity

QA activity:

vercel bot commented Dec 6, 2022 • edited Loading

github-actions bot commented Dec 6, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankitakinger left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ankitakinger left a comment

Choose a reason for hiding this comment

Aishwarya-U-R commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

jsartisan commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

jsartisan commented Dec 9, 2022

github-actions bot commented Dec 9, 2022

coderabbitai bot commented Aug 6, 2024

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

jsartisan commented Dec 6, 2022 •

edited

Loading

vercel bot commented Dec 6, 2022 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)