feat: New email templates #18754
Closed
feat: New email templates #18754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shrikant Sharat Kandula <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nidhi-nair
reviewed
Dec 7, 2022
| } else { | ||
| params.put("Inviter_First_Name", inviter.getEmail()); | ||
| } | ||
| params.put("inviterFirstName", org.apache.commons.lang3.StringUtils.defaultIfEmpty(inviter.getName(), inviter.getEmail())); |
There was a problem hiding this comment.
LGTM, except for this ugly import. Should we be trying to use only one library for string manipulations?
There was a problem hiding this comment.
Yes, I put up a note in my list, and intend to get back to refactoring this. I tried doing it in this PR itself, but it's not a on-line change, as other calls to StringUtils in this class will change. Didn't want to do that here.
I'll clean this up as a separate PR soon.
dilippitchika
previously approved these changes
Dec 8, 2022
Signed-off-by: Shrikant Sharat Kandula <[email protected]>
|
Closing as the code here has been implemented in #18717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.