feat: embed settings

[akash-codemonk]

Description

Adds a UI for updating the allowed frame ancestors value.

https://theappsmith.slack.com/archives/C02JT9CSE6L/p1664371030083979 has the details for the deploy preview.

• Adds a new radio control.
• Created a new type ControlType to have type validation based on the control type used.
• The values entered in limit embedding url input are stored in local storage to persist these values for later use.
• Set type of setting in form group components tests due to type errors after adding ControlType type.
• Updated the style of TagInput's in group.tsx.

demo.mov

Related to #15661

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Cypress

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
appsmith	⬜️ Ignored (Inspect)		Nov 22, 2022 at 4:59AM (UTC)

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[Richarex]

@RoopKrrish9696 can we please have a hover state for Embed Settings radio button & Limit embedding to certain URLs text field

[ginilpg]

@ankitakinger All of your review comments have been addressed. Could you please review this again?

[ankitakinger]

@akash-codemonk Below are the things which needs to be looked at IMO:

1. EE repo needs a separate PR for this change for the file appsmith-ee/app/client/src/ee/pages/AdminSettings/config/general.tsx as the embed settings will get removed on EE if this is not done.
2. Can we use the same design-system colors for Radio buttons? (Orange instead of black) It looks weird where everything is Orange, but the Radio buttons are black.
3. Cursor on the cross buttons of the tags in the tag input field is not a pointer, while it was earlier.
4. The UI is changing a bit here for tags, hence tagging @vinay-appsmith for his inputs on how he thinks the tags UI should look on the Admin settings page
   Before:

After:

@vinay-appsmith Ref: This is OIDC settings page on EE Admin settings 5. Also, I feel this part of the page is a little clumsy, its not a blocker but just thought to point it out. Can we do something about this?

[ankitakinger]

can we add this margin: 0 back to the CSS @akash-codemonk?

[RoopKrrish9696]

@ankitakinger Regarding the points you made:

1. For point 2, according to the DS, we use black colour for radio buttons/checkboxes. The ones used before must be old designs IMO. For DS reference .
2. For point 4, we don't have a tag input component, I tried to use the RBAC ones. I think @vinay-appsmith can help here.

[vinay-appsmith]

@ankitakinger @RoopKrrish9696 There is a mismatch with the design system figma file and the design system repo in Storybook. Some of the component designs in Figma haven't been translated to code, yet - which is why you see these differences (orange vs. black).

Stick to the DS repo as much as possible because it will help in making the changes fast when we review the color across the components in our system. (this is happening in the next 2 weeks, iirc)

An exception to the above statement is the tags component. This needs to change to the design that is shared in the thread above (2nd image). The orange on the tags is just too bright. This change needs to happen at the DS level.

[akash-codemonk]

1. Will create a PR there once this PR is merged.
2. So we are going with orange i.e same as the default color used by the design system repo? @RoopKrrish9696

3. Will fix this
4. For taginputs we want to go with the default design system colors? We want to update the brightness of orange but that will happen in the design system repo. @RoopKrrish9696 @vinay-appsmith

[ankitakinger]

LGTM. Make sure you create a PR on EE as well as stated earlier.

[akash-codemonk]

/ok-to-test sha=614337b

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3515719922.
Workflow: Appsmith External Integration Test Workflow.
Commit: 614337b.
PR: 16629.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16629&runId=3515719922_1

[vercel]

Deployment failed with the following error:

Resource is limited - try again in 8 minutes (more than 100, code: "api-deployments-free-per-day").

[akash-codemonk]

/ok-to-test sha=3a70471

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3520581210.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3a70471.
PR: 16629.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-63465d4789020c7ac296d08d?pr=16629&runId=3520581210_1

[coderabbitai]

Warning

Rate limit exceeded

@Nikhil-Nandagopal has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 57 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 22550d6 and 3a70471.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.