Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: single quotes being escaped in env variables #16987

Closed
akash-codemonk opened this issue Sep 22, 2022 · 0 comments · Fixed by #16983
Closed

[Bug]: single quotes being escaped in env variables #16987

akash-codemonk opened this issue Sep 22, 2022 · 0 comments · Fixed by #16983
Assignees
Labels
Backend This marks the issue or pull request to reference server code Bug Something isn't working DevOps Pod Issues related to devops

Comments

@akash-codemonk
Copy link
Contributor

@sharat87 Sending a value with quotes to the api(v1/admin/env) is resulting in quotes getting escaped. Added some points below which describes the issue.

settings.mov

none

If I send the value as 'none' from the client it stores it as none without the quotes in the env file. Checking on the browser also shows none without quotes. I believe it should be APPSMITH_ALLOWED_FRAME_ANCESTORS="'none'" instead.

  1. Same case with sending 'self'

  2. Additionally if I send the value as 'self' release.app.appsmith.com the env file stores it as

release

In this case it does get applied properly though when I check the same in the browser

browser

  1. This seems the case with all the fields but in case of APPSMITH_ALLOWED_FRAME_ANCESTORS we probably have to preserve/not escape the quotes.

If you want the frontend to debug it is at #16629

Originally posted by @akash-codemonk in #16597 (comment)

@akash-codemonk akash-codemonk added Bug Something isn't working Backend This marks the issue or pull request to reference server code Super Admin labels Sep 22, 2022
@github-actions github-actions bot added the DevOps Pod Issues related to devops label Sep 22, 2022
@close-label close-label bot added the QA Needs QA attention label Sep 29, 2022
@yatinappsmith yatinappsmith removed the QA Needs QA attention label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend This marks the issue or pull request to reference server code Bug Something isn't working DevOps Pod Issues related to devops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants