Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http-netty: Disable the ClientEffectiveStrategyTest suite #3075

Merged
merged 2 commits into from
Oct 11, 2024
+2 −0
Merged

http-netty: Disable the ClientEffectiveStrategyTest suite #3075

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03020e3
http-netty: Disable the ClientEffectiveStrategyTest suite
bryce-anderson Oct 8, 2024
f062d54
Use disabled instead
bryce-anderson Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...etalk-http-netty/src/test/java/io/servicetalk/http/netty/ClientEffectiveStrategyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
import org.hamcrest.Matchers;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.extension.RegisterExtension;
import org.junit.jupiter.api.parallel.Execution;
import org.junit.jupiter.api.parallel.ExecutionMode;
Expand Down Expand Up @@ -227,6 +228,7 @@ static Stream<Arguments> casesSupplier() {
return arguments.stream();
}

@Disabled // Disabled due to continued flakiness. See issue #2245 for more details.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryce-anderson This test is very important. It helps to validate that we correctly compute the effective strategy based on all default filters and modules bundled together by default. If we disable it completely, we open a risk to missing a bug that will have a significant performance hit (for example, if we add a filter with non-overridden requireOffloads() method). We had that in the past.

Instead of disabling all of them, consider using assumeThat(...) statement to disable (with comment) only those test cases that are flaky based on #2245 records. That will help us to make sure the effective strategy is computed correctly if at least some APIs are validated.

@ParameterizedTest(name = "Type={0} builder={1} filter={2} LB={3} CF={4}")
@MethodSource("casesSupplier")
void clientStrategy(final BuilderType builderType,
Expand Down
Loading