http-netty: Disable the ClientEffectiveStrategyTest suite #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The ClientEffectiveStrategyTest suite has been flaky for a long time and multiple engineers have looked at it, without making progress. In the meantime, this suite causes a substantial fraction of the failed runs. Modifications: Mark the flaky test as @ignored. Result: CI should be significantly less flaky.
daschl
approved these changes
Oct 9, 2024
bryce-anderson
deleted the
bl_anderson/disable-ClientEffectiveStrategyTest
branch
| @@ -227,6 +228,7 @@ static Stream<Arguments> casesSupplier() { | |||
| return arguments.stream(); | |||
| } | |||
|
|
|||
| @Disabled // Disabled due to continued flakiness. See issue #2245 for more details. | |||
There was a problem hiding this comment.
@bryce-anderson This test is very important. It helps to validate that we correctly compute the effective strategy based on all default filters and modules bundled together by default. If we disable it completely, we open a risk to missing a bug that will have a significant performance hit (for example, if we add a filter with non-overridden requireOffloads() method). We had that in the past.
Instead of disabling all of them, consider using assumeThat(...) statement to disable (with comment) only those test cases that are flaky based on #2245 records. That will help us to make sure the effective strategy is computed correctly if at least some APIs are validated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The ClientEffectiveStrategyTest suite has been flaky for a long time and multiple engineers have looked at it, without making progress. In the meantime, this suite causes a substantial fraction of the failed runs.
Modifications:
Mark the flaky test as
@Disabled.Result:
CI should be significantly less flaky.
Related to #2245.