Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Rotate endpoint #756

Merged
merged 4 commits into from
Mar 13, 2024
Merged

chore: Remove Rotate endpoint #756

merged 4 commits into from
Mar 13, 2024

Conversation

Dor-bl
Copy link
Collaborator

@Dor-bl Dor-bl commented Mar 12, 2024

List of changes

Since Rotate is not implemented, it's misleading to have the option to call this endpoint.
This PR will remove any related code

See related PR: appium/appium#19379
See related issue: #755

Types of changes

What types of changes are you proposing/introducing to the .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Please provide more details about changes if it is necessary. You can provide code samples showing how they work and possible use cases if there are new features. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub

@Dor-bl Dor-bl added the Chore label Mar 12, 2024
@Dor-bl Dor-bl linked an issue Mar 12, 2024 that may be closed by this pull request
@Dor-bl Dor-bl merged commit e8c6d92 into appium:main Mar 13, 2024
3 checks passed
@Dor-bl Dor-bl deleted the remove_rotate branch March 13, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotate throw System.NotImplementedException
3 participants