Rotate throw System.NotImplementedException

[ptittof57]

Description

Hello,

I try to perfom a device rotation with the following code:

    [Test]
    public void RotationTest()
    {
        var rotation90Degrees = new Dictionary<string, int>
        {
            { "rotation", 90 },
        };

        this.Driver.Rotate(rotation90Degrees);

        Assert.IsTrue(this.Driver.Orientation == ScreenOrientation.Landscape);
    }

But I receive an exception.

Environment

• .NET client build version or git revision if you use some snapshot: Appium.WebDriver - 5.0.0-rc.6
• Appium server version or git revision if you use some snapshot: 2.4.1
• Desktop OS/version used to run Appium if necessary: MacOs Sonoma 14.3.1
• Node.js version (unless using Appium.app|exe) or Appium CLI or Appium.app|exe: 20.11.1
• Mobile platform/version under test: Android (API28) and iOS (iPhone 15 Pro iOS 17.2)
• Real device or emulator/simulator: both Android and iOS simulators

Exception stack traces

Exception has occurred: CLR/System.NotImplementedException
An exception of type 'System.NotImplementedException' occurred in WebDriver.dll but was not handled in user code: 'The requested resource could not be found, or a request was received using an HTTP method that is not supported by the mapped resource'
at OpenQA.Selenium.WebDriver.UnpackAndThrowOnError(Response errorResponse, String commandToExecute)
at OpenQA.Selenium.WebDriver.Execute(String driverCommandToExecute, Dictionary2 parameters)
at OpenQA.Selenium.Appium.AppiumDriver.Execute(String driverCommandToExecute, Dictionary2 parameters)
at OpenQA.Selenium.Appium.AppiumDriver.Rotate(Dictionary2 opts)
at UITests.DashboardTest.RotationTest()

Let me know if I am doing something wrong or if this feature is not implemented yet.
Thanks

[KazuCocoa]

Could you share the appium server log as well? I assume

dotnet-client/src/Appium.Net/Appium/AppiumDriverCommand.cs

Line 289 in 23ae815

public const string SetOrientation = "setOrientation";

would work for now

[Dor-bl]

@ptittof57
This should do the trick

            _driver.Orientation = ScreenOrientation.Landscape;
            Assert.That(_driver.Orientation == ScreenOrientation.Landscape);

@KazuCocoa I deprecate the rotate method? what's the status of other appium clients?

[KazuCocoa]

The rotate does not have much usage, and it is not w3c. It is safe to remove it I think.
Python and Ruby clients do not have the rotation endpoint call. Java still has. They have the orientation endpoint call.

[Dor-bl]

@KazuCocoa Any idea what Rotate on Element is supposed to do?
Maybe it's a mistake.
Anyway, I'm getting for this one System.NotImplementedException: 'Method has not yet been implemented' as well
https://github.com/appium/dotnet-client/blob/main/src/Appium.Net/Appium/AppiumElement.cs#L199-L208

[KazuCocoa]

Perhaps it is for appium/appium#19379 . The implementation did not exist on current drivers. Thus, I removed that endpoint.

[Dor-bl]

Perhaps it is for appium/appium#19379 . The implementation did not exist on current drivers. Thus, I removed that endpoint.

Great, so it's safe to remove this method as well and the related endpoint on our side

[mykola-mokhnach]

I'd say rotation could be implemented as an extension method.
Also, to add on that:

• Orientation is limited. It only supports portrait and landscape, while rotation supports various angles (in reality for iOS and Android it adds two more possible states)
• Rotation (and orientation) are not applicable for all drivers