Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add ignoreUpstreamProxyCertificate tests #583

Merged
merged 4 commits into from
Apr 4, 2025
Merged

test: add ignoreUpstreamProxyCertificate tests #583

merged 4 commits into from
Apr 4, 2025

Conversation

lewis-wow
Copy link
Contributor

@lewis-wow lewis-wow commented Mar 31, 2025 •
edited
Loading

Add tests for ignoreUpstreamProxyCertificate proxy chain server prepareRequestFunction option.

@lewis-wow lewis-wow linked an issue Mar 31, 2025 that may be closed by this pull request
Add a test for HTTPS proxy #581
Closed
@github-actions github-actions bot added this to the 111th sprint - Platform team milestone Mar 31, 2025
@github-actions github-actions bot added t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics. labels Mar 31, 2025
@lewis-wow lewis-wow force-pushed the test/add-ignore-upstream-proxy-certificate-test branch from 5fdea51 to 097248b Compare March 31, 2025 13:12
@lewis-wow lewis-wow requested a review from jirimoravcik March 31, 2025 13:57
jirimoravcik
jirimoravcik reviewed Mar 31, 2025
View reviewed changes
Copy link
Member

@jirimoravcik jirimoravcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please bump the version in package.json to 2.5.9? Thanks

@lewis-wow lewis-wow requested a review from jirimoravcik March 31, 2025 14:13
@lewis-wow lewis-wow marked this pull request as ready for review March 31, 2025 14:13
jirimoravcik
jirimoravcik approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@jirimoravcik jirimoravcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. Maybe it would be nice to add a comment describing how the test works?

@lewis-wow lewis-wow merged commit ec1ab92 into master Apr 4, 2025
5 checks passed
@lewis-wow lewis-wow deleted the test/add-ignore-upstream-proxy-certificate-test branch April 4, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirimoravcik jirimoravcik jirimoravcik approved these changes

Assignees

@lewis-wow lewis-wow

Labels
t-platform Issues with this label are in the ownership of the platform team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Milestone
111th sprint - Platform team
Development

Successfully merging this pull request may close these issues.

Add a test for HTTPS proxy
2 participants
@lewis-wow @jirimoravcik