Skip to content

Add a test for HTTPS proxy #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jirimoravcik opened this issue Mar 31, 2025 · 0 comments · Fixed by #583
Closed

Add a test for HTTPS proxy #581

jirimoravcik opened this issue Mar 31, 2025 · 0 comments · Fixed by #583
Assignees
@lewis-wow
Labels
backend Issues related to the platform backend. good first issue Good for newcomers. low priority Low priority issues to be done eventually. t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.

Comments

@jirimoravcik
Copy link
Member

We recently added a new option ignoreProxyCertificate. We should add tests covering it.

How to do it (roughly):

  1. Run a plain Node.js HTTP server that would just return Hello world.
  2. Use e.g. https://www.npmjs.com/package/local-ssl-proxy to wrap the server with a self-signed SSL certificate.
  3. Run a proxy-chain server that would point to the HTTPS endpoint created in 2.
  4. Send a normal request via the proxy-chain proxy.
  5. If ignoreProxyCertificate is set to true, you should get Hello world, otherwise you'll get a SSL error about being unable to verify the leaf signature.
@jirimoravcik jirimoravcik added backend Issues related to the platform backend. good first issue Good for newcomers. low priority Low priority issues to be done eventually. t-platform Issues with this label are in the ownership of the platform team. labels Mar 31, 2025
@lewis-wow lewis-wow linked a pull request Mar 31, 2025 that will close this issue
test: add ignoreUpstreamProxyCertificate tests #583
Merged
@fnesveda fnesveda added the validated Issues that are resolved and their solutions fulfill the acceptance criteria. label Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lewis-wow lewis-wow

Labels
backend Issues related to the platform backend. good first issue Good for newcomers. low priority Low priority issues to be done eventually. t-platform Issues with this label are in the ownership of the platform team. validated Issues that are resolved and their solutions fulfill the acceptance criteria.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add ignoreUpstreamProxyCertificate tests apify/proxy-chain
3 participants
@jirimoravcik @fnesveda @lewis-wow