-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve pnpm support for dashboard build scripts. #232
base: master
Are you sure you want to change the base?
Conversation
Looks like that this PR isn't finished yet? |
Yes, but if the apisix build tool is not changed during the merge, the packaged RPM workflow of the merged PR will have an error. (after all, you are upstream of RPM workflow) Do you want to copy this script to the local warehouse or request you to change this tool. We need to discuss it for some time. At that time, we will close this PR or request changes to the merge tool. |
Update, the task has been completed Wait for @bzp2010 's opinions |
ping @bzp2010 does this PR is needed? |
I think we need to wait for the PR merge in the APISIX Dashboard project before doing this. BTW, I don't think using pnpm in the build session will help a lot with build speed, but it will improve our development experience. |
|
I am working on the APISIX dashboard project to migrate its package manager from yarn to pnpm. His GitHub workflow uses this script to detect RPM packaging. We need some minor changes to make the workflow work normally.
apache/apisix-dashboard#2604