Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move from yarn to pnpm #2602

Closed
wants to merge 28 commits into from

Conversation

FangSen9000
Copy link
Contributor

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Objective: the purpose of this PR is to introduce advanced and popular pnpm package management tools and use pnpm to download dependency packages faster.

Effect: pnpm will be the next generation package management tool of dashboard. Migrate the package manager from the original yarn to pnpm to reduce dependency installation and compilation time.

Changes: package.json, pnpm-lock.yaml, related GitHub workflow files. The relevant documents have been updated, solutions have been written for possible problems in use, and the workflow is running normally.

The related PR

#2459

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@@ -49,7 +49,7 @@ jobs:
run: |
export VERSION=${{ steps.branch_env.outputs.version }}
sudo gem install --no-document fpm
git clone https://github.com/api7/apisix-build-tools.git
git clone https://github.com/FangSen9000/apisix-build-tools.git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we should let the API7 community merge my changes to the build script before merging this pr.
api7/apisix-build-tools#232
(if I keep it as it is, the original warehouse that has not been changed will only report an error. In order to prove that my changes are effective, I link to my modified build script warehouse.)

@FangSen9000
Copy link
Contributor Author

FangSen9000 commented Aug 24, 2022

On the basis of the latest major modification of young, I changed it to pnpm again.
#2583

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #2602 (53e3c8d) into master (0458664) will decrease coverage by 2.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2602      +/-   ##
==========================================
- Coverage   68.50%   65.70%   -2.81%     
==========================================
  Files         134       37      -97     
  Lines        3553      971    -2582     
  Branches      867      267     -600     
==========================================
- Hits         2434      638    -1796     
+ Misses       1119      333     -786     
Flag Coverage Δ
frontend-e2e-test 65.70% <ø> (-2.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/helpers.tsx 19.67% <0.00%> (-50.82%) ⬇️
web/src/components/RightContent/AvatarDropdown.tsx 50.00% <0.00%> (-32.15%) ⬇️
web/src/components/PanelSection/index.tsx 75.00% <0.00%> (-25.00%) ⬇️
web/src/pages/Consumer/List.tsx 69.44% <0.00%> (-22.23%) ⬇️
...b/src/components/Plugin/UI/referer-restriction.tsx 69.69% <0.00%> (-21.22%) ⬇️
web/src/components/ActionBar/ActionBar.tsx 69.23% <0.00%> (-15.39%) ⬇️
web/src/components/Plugin/PluginPage.tsx 82.00% <0.00%> (-15.00%) ⬇️
web/src/app.tsx 87.87% <0.00%> (-12.13%) ⬇️
web/src/components/Plugin/UI/cors.tsx 71.11% <0.00%> (-11.12%) ⬇️
web/src/components/RawDataEditor/RawDataEditor.tsx 28.57% <0.00%> (-10.39%) ⬇️
... and 102 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants