ZOOKEEPER-3594: Don't propose error transactions #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezhuw
commented
Sep 27, 2023
| case Leader.SKIP: | ||
| // It is sad that we have no breadcrumbs to route packet back to origin. Basically, we have choices: | ||
| // 1. Attach breadcrumbs to outstanding request. | ||
| // This request protocol changes and protocol version bumping. |
There was a problem hiding this comment.
I think we could also cover #2069 if we want to go this way. I prefer this actually. We will inevitably introduce protocol changes in long term future. If so, why now ? But it still could be a separate issue before 3.10.0.
| @BeforeEach | ||
| @Override | ||
| public void setUp() throws Exception { | ||
| // TODO: setup an follower as observer master. |
There was a problem hiding this comment.
I am working on this. I could be a bit late due to my personal schedule.
As discussions in ZOOKEEPER-3418 and ZOOKEEPER-3594, there is no reason for us to propose error transactions. It is a waste of both network traffic/latency and disk storage. This pr introduces a new quorum packet type `SKIP`. Leader uses it to signal request owner to abort pending request. Since `SKIP` is a new packet type, so `skipErrorTxn` must not be turned on during rolling upgrade. JIRA: ZOOKEEPER-3594
kezhuw
force-pushed
the
ZOOKEEPER-3594-not-propose-error-transactions
branch
from
abb2747 to
8c7bfc6
Compare
|
Can i contribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussions in ZOOKEEPER-3418 and ZOOKEEPER-3594, there is no reason for us to propose error transactions. It is a waste of both network traffic/latency and disk storage.
This pr introduces a new quorum packet type
SKIP. Leader uses it to signal request owner to abort pending request.Since
SKIPis a new packet type, soskipErrorTxnmust not be turned on during rolling upgrade.JIRA: ZOOKEEPER-3594(#1172)