Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Zeta][Core] Support output log file of job #7712

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[Feature][Zeta][Core] Support output log file of job #7712

merged 1 commit into from
Sep 24, 2024

Conversation

hailin0
Copy link
Member

@hailin0 hailin0 commented Sep 21, 2024 •
edited
Loading

Purpose of this pull request

[Feature][Zeta][Core] Support output log file of job

ref
https://logging.apache.org/log4j/2.x/manual/appenders/delegating.html#RoutingAppender

Does this PR introduce any user-facing change?

No

How was this patch tested?

Added

Check list

@github-actions github-actions bot added the e2e label Sep 21, 2024
@hailin0
Copy link
Member Author

hailin0 commented Sep 21, 2024

subtask of #7491

@hailin0
Copy link
Member Author

hailin0 commented Sep 21, 2024

cc @arshadmohammad

@hailin0
Copy link
Member Author

hailin0 commented Sep 21, 2024

local testcase

image

@hailin0 hailin0 marked this pull request as ready for review September 21, 2024 17:38
@hailin0 hailin0 added the core SeaTunnel core module label Sep 21, 2024
@dailai
Copy link
Contributor

dailai commented Sep 23, 2024

I think we should add a doc to introduce this feature. It's a great job.

@hailin0 hailin0 mentioned this pull request Sep 23, 2024
Closed
3 tasks
@hailin0
Copy link
Member Author

hailin0 commented Sep 23, 2024

I think we should add a doc to introduce this feature. It's a great job.

Completed by this subtasks #7716

@Hisoka-X
Copy link
Member

Could you add new doc part of logging? Just like flink https://nightlies.apache.org/flink/flink-docs-release-1.20/docs/deployment/advanced/logging/

We should share to users how to configure different log output.

Hisoka-X
Hisoka-X reviewed Sep 23, 2024
View reviewed changes
config/log4j2.properties Outdated Show resolved Hide resolved
config/log4j2.properties Outdated Show resolved Hide resolved
@Hisoka-X Hisoka-X added this to the 2.3.8 milestone Sep 23, 2024
@github-actions github-actions bot added document and removed core SeaTunnel core module labels Sep 23, 2024
@hailin0
Copy link
Member Author

hailin0 commented Sep 23, 2024

Could you add new doc part of logging? Just like flink https://nightlies.apache.org/flink/flink-docs-release-1.20/docs/deployment/advanced/logging/

We should share to users how to configure different log output.

added

@arshadmohammad
Copy link
Collaborator

Thank you, @hailin0, for working on this feature.
Could you please confirm if an API has been added for seatunnel-web to interact with seatunnel to retrieve logs?

@hailin0
Copy link
Member Author

hailin0 commented Sep 23, 2024

Thank you, @hailin0, for working on this feature. Could you please confirm if an API has been added for seatunnel-web to interact with seatunnel to retrieve logs?

@arshadmohammad
You can create an issue to describe your feature request

Hisoka-X
Hisoka-X approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@arshadmohammad
Copy link
Collaborator

@arshadmohammad You can create an issue to describe your feature request
Sure, I will create

@arshadmohammad arshadmohammad mentioned this pull request Sep 23, 2024
Closed
3 tasks
@arshadmohammad
Copy link
Collaborator

Created #7724

Carl-Zhou-CN
Carl-Zhou-CN approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hailin0 hailin0 merged commit 0261f86 into apache:dev Sep 24, 2024
7 checks passed
This was referenced Oct 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carl-Zhou-CN Carl-Zhou-CN Carl-Zhou-CN approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees
No one assigned
Labels
approved document e2e reviewed
Projects
None yet
Milestone
2.3.8
Development

Successfully merging this pull request may close these issues.
5 participants
@hailin0 @dailai @Hisoka-X @arshadmohammad @Carl-Zhou-CN