-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Zeta][Core] Support api get logs #7818
Conversation
Please add test cases in RestApiIT |
According to #7647, we need to implement the V2 version of the api |
https://github.com/apache/seatunnel/blob/dev/docs/en/seatunnel-engine/rest-api-v2.md Please maintain documentation here. |
ok, thank you for your reminder |
good pr |
Please resolve code conflicts |
...ver/src/main/java/org/apache/seatunnel/engine/server/rest/servlet/CurrentNodeLogServlet.java
Show resolved
Hide resolved
good job |
Please update https://github.com/apache/seatunnel/blob/934434cc75afc747339182df6468f89a5d0fb1b2/docs/en/seatunnel-engine/logging.md to tell user we can get logs by rest api. |
...nector-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/joblog/JobLogIT.java
Outdated
Show resolved
Hide resolved
...erver/src/main/java/org/apache/seatunnel/engine/server/rest/RestHttpGetCommandProcessor.java
Outdated
Show resolved
Hide resolved
...-server/src/main/java/org/apache/seatunnel/engine/server/rest/servlet/AllLogNameServlet.java
Outdated
Show resolved
Hide resolved
|
||
Returns a list of logs from the requested node. | ||
|
||
#### Examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I use http://localhost:5801/log/12345
to get job 12345
's logs in current node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I use
http://localhost:5801/log/12345
to getjob 12345
's logs in current node?
Currently not supported, /log can only be matched accurately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @zhangshenghang
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.