[Feature] Add tidb datatype convertor #5440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ic4y
previously approved these changes
Sep 14, 2023
Hisoka-X
changed the title
|
Shall we add some test case for it? |
If need to add test cases, I can also add, but I don't know how to test this， |
Got it. |
Hisoka-X
reviewed
Sep 14, 2023
| return toSeaTunnelType(mysqlType, dataTypeProperties); | ||
| } | ||
|
|
||
| // todo: It's better to wrapper MysqlType to a pojo in ST, since MysqlType doesn't contains |
There was a problem hiding this comment.
contains properties. This place uses MysqlDataTypeConvertor, so take the annotations too QAQ
Hisoka-X
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide
release-note.