Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs][Connector][Source][mysql]Added the mysql Connector Document version title Example pr #5249

Merged
merged 7 commits into from
Sep 5, 2023

Conversation

zhilinli123
Copy link
Contributor

@zhilinli123 zhilinli123 commented Aug 9, 2023

Issues:#4803

Purpose of this pull request

Check list

@zhilinli123
Copy link
Contributor Author

PTAL: @liugddx @ic4y

@@ -2,6 +2,10 @@

> JDBC Mysql Sink Connector

## Support Connector Version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase 'Support Connector Version' is definitely not accurate. Consider using 'Support Mysql Version', 'Support Version', and so on.

liugddx
liugddx previously approved these changes Aug 15, 2023
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

docs/en/connector-v2/sink/Mysql.md Outdated Show resolved Hide resolved
docs/en/connector-v2/source/Mysql.md Outdated Show resolved Hide resolved
@liugddx liugddx merged commit c109385 into apache:dev Sep 5, 2023
33 checks passed
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
…rsion title Example pr (apache#5249)

* [Docs][Connector][Source][mysql]Added the mysql Connector Document version title Example pr

* [Docs][Connector][Source][mysql]Added the mysql Connector Document version title Example pr apache#5249

* Update docs/en/connector-v2/sink/Mysql.md

* Update docs/en/connector-v2/source/Mysql.md

---------

Co-authored-by: Jia Fan <[email protected]>
Zhouwen-CN pushed a commit to Zhouwen-CN/seatunnel that referenced this pull request Sep 11, 2023
…rsion title Example pr (apache#5249)

* [Docs][Connector][Source][mysql]Added the mysql Connector Document version title Example pr

* [Docs][Connector][Source][mysql]Added the mysql Connector Document version title Example pr apache#5249

* Update docs/en/connector-v2/sink/Mysql.md

* Update docs/en/connector-v2/source/Mysql.md

---------

Co-authored-by: Jia Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants