Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Connector-V2] jdbc connector supports Kingbase database #4803

Merged
merged 52 commits into from
Sep 13, 2023
Merged

[Feature][Connector-V2] jdbc connector supports Kingbase database #4803

merged 52 commits into from
Sep 13, 2023

Conversation

NickCodeJourney
Copy link
Contributor

@NickCodeJourney NickCodeJourney commented May 22, 2023 •
edited
Loading

close #4512
close #4758

Purpose of this pull request

Check list

@hailin0
Copy link
Member

hailin0 commented May 22, 2023

why close？

@hailin0
Copy link
Member

hailin0 commented May 23, 2023

please add e2e testcase
https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e

@NickCodeJourney NickCodeJourney changed the title [Feature][Connector-V2] jdbc connector supports KingbaseES database [Feature][Connector-V2] jdbc connector supports Kingbase database Jul 7, 2023
@NickCodeJourney NickCodeJourney marked this pull request as ready for review August 10, 2023 05:59
@NickCodeJourney
Copy link
Contributor Author

You need to put the screenshot of the e2e test here

it's above and it's folded

yangpeng added 3 commits August 10, 2023 15:31
🐛 fix doc
268d2df
🐛 fix doc
bedbcab
📝 Refine formatting in data type mapping tables
ee4785d 
The formatting in the data type mapping tables for both the source and sink documents has been refined. This change mainly involves adjusting alignment and spacing to improve readability. No change in the content, only the format.
@NickCodeJourney NickCodeJourney deleted the branch apache:dev August 11, 2023 02:44
@NickCodeJourney
Copy link
Contributor Author

You need to put the screenshot of the e2e test here

#4803 (comment)
#4803 (comment)

liugddx
liugddx approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@liugddx liugddx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liugddx
Copy link
Member

liugddx commented Aug 15, 2023

LGTM

Please screenshot the test results. PTAL @ic4y

@NickCodeJourney
Copy link
Contributor Author

LGTM

Please screenshot the test results. PTAL @ic4y

Snipaste_2023-08-15_11-19-09 Snipaste_2023-08-15_11-18-02

This was referenced Aug 16, 2023
Closed
Closed
@EricJoy2048 EricJoy2048 merged commit 9538567 into apache:dev Sep 13, 2023
87 checks passed
gnehil pushed a commit to gnehil/seatunnel that referenced this pull request Oct 12, 2023
@NickCodeJourney
[Feature][Connector-V2] jdbc connector supports Kingbase database (ap…
043320e 
…ache#4803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@liugddx liugddx liugddx approved these changes

@zhilinli123 zhilinli123 zhilinli123 approved these changes

@Hisoka-X Hisoka-X Awaiting requested review from Hisoka-X

@TyrantLucifer TyrantLucifer Awaiting requested review from TyrantLucifer

Assignees
No one assigned
Labels
approved First-time contributor First-time contributor reviewed
Projects
None yet
Milestone
No milestone
9 participants
@NickCodeJourney @hailin0 @CheneyYin @liugddx @zhilinli123 @EricJoy2048 @Hisoka-X @TyrantLucifer @davidzollo