[Feature][Connector-V2] Introduce milvus sink connector #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By https://platform.openai.com/docs/api-reference/embeddings vectorizing the book title to store the database |
liugddx
changed the title
EricJoy2048
reviewed
Jun 15, 2023
3 tasks
|
good |
hailin0
reviewed
Jul 20, 2023
Comment on lines
+55
to
+62
| c_int = int | ||
| c_array = array<float> | ||
| c_tinyint = tinyint | ||
| c_smallint = smallint | ||
| c_bigint = bigint | ||
| c_float = float | ||
| c_double = double | ||
| c_bol = "boolean" |
There was a problem hiding this comment.
test all support datatypes？
Milvus currently supports these data types.
https://milvus.io/docs/schema.md#Supported-data-type
liugddx
changed the title
ic4y
previously approved these changes
Aug 5, 2023
Hisoka-X
reviewed
Aug 18, 2023
docs/en/connector-v2/sink/Milvus.md
Outdated
| @@ -0,0 +1,85 @@ | |||
| # Milvus | |||
There was a problem hiding this comment.
Please use new document template, like #5132
Hisoka-X
reviewed
Aug 24, 2023
docs/en/connector-v2/sink/Milvus.md
Outdated
Comment on lines
48
to
60
| ```hocon | ||
| sink { | ||
| Milvus { | ||
| milvus_host = localhost | ||
| milvus_port = 19530 | ||
| username = root | ||
| password = Milvus | ||
| collection_name = title_db | ||
| openai_engine = text-embedding-ada-002 | ||
| openai_api_key = sk-xxxx | ||
| embeddings_fields = title_2 | ||
| } | ||
| ``` |
There was a problem hiding this comment.
I think you should put a demo can run without any modify. Not just sink config. It's more useful.
Comment on lines
41
to
66
| public MilvusOptions(Config config) { | ||
| this.milvusHost = config.getString(MilvusConfig.MILVUS_HOST.key()); | ||
| if (config.hasPath(MilvusConfig.MILVUS_PORT.key())) { | ||
| this.milvusPort = config.getInt(MilvusConfig.MILVUS_PORT.key()); | ||
| } else { | ||
| this.milvusPort = MilvusConfig.MILVUS_PORT.defaultValue(); | ||
| } | ||
| this.collectionName = config.getString(MilvusConfig.COLLECTION_NAME.key()); | ||
| this.userName = config.getString(MilvusConfig.USERNAME.key()); | ||
| this.password = config.getString(MilvusConfig.PASSWORD.key()); | ||
|
|
||
| if (config.hasPath(MilvusConfig.PARTITION_FIELD.key())) { | ||
| this.partitionField = config.getString(MilvusConfig.PARTITION_FIELD.key()); | ||
| } | ||
| if (config.hasPath(MilvusConfig.OPENAI_ENGINE.key())) { | ||
| this.openaiEngine = config.getString(MilvusConfig.OPENAI_ENGINE.key()); | ||
| } else { | ||
| this.openaiEngine = MilvusConfig.OPENAI_ENGINE.defaultValue(); | ||
| } | ||
| if (config.hasPath(MilvusConfig.OPENAI_API_KEY.key())) { | ||
| this.openaiApiKey = config.getString(MilvusConfig.OPENAI_API_KEY.key()); | ||
| } | ||
| if (config.hasPath(MilvusConfig.EMBEDDINGS_FIELDS.key())) { | ||
| this.embeddingsFields = config.getString(MilvusConfig.EMBEDDINGS_FIELDS.key()); | ||
| } | ||
| } |
There was a problem hiding this comment.
You can use ReadonlyConfig readonlyConfig = ReadonlyConfig.fromConfig(config);. Then just use readonlyConfig.get(MilvusConfig.MILVUS_HOST), it will hande default value.
Comment on lines
57
to
62
| CheckResult result = | ||
| CheckConfigUtil.checkAllExists( | ||
| pluginConfig, | ||
| MilvusConfig.MILVUS_HOST.key(), | ||
| MilvusConfig.MILVUS_PORT.key(), | ||
| MilvusConfig.COLLECTION_NAME.key()); |
There was a problem hiding this comment.
Use OptionRule to check config is valid or not.
eg:
ConfigValidator.of(config).validate(new JdbcSourceFactory().optionRule());
...us/src/main/java/org/apache/seatunnel/connectors/seatunnel/milvus/sink/MilvusSinkWriter.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide
release-note.