Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename broker-rbac.yaml to function-worker-rbac.yaml #452

Closed
wants to merge 4 commits into from
Closed

rename broker-rbac.yaml to function-worker-rbac.yaml #452

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf314ba
rename broker-rbac.yaml to function-worker-rbac.yaml
Jan 30, 2024
5f1175e
set check for rbac enabled
Jan 30, 2024
f6fdcfc
remove psp flag and only rely on rbac flag
Jan 30, 2024
a52254d
remove rbac check + rename file
Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/pulsar/templates/broker-rbac.yaml → ...ulsar/templates/function-worker-rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
# under the License.
#

{{- if .Values.rbac.enabled }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this condition will break Pulsar Functions support. It is mandatory when .Values.components.functions is enabled. That's why adding this condition is problematic. Perhaps we instead need to clarify the documentation of rbac.enabled and explain that RBAC will be always configured for Pulsar Functions regardless of rbac.enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will remove it from this PR.

{{- if or .Values.components.functions .Values.extra.functionsAsPods }}
apiVersion: rbac.authorization.k8s.io/v1
{{- if .Values.functions.rbac.limit_to_namespace }}
Expand Down Expand Up @@ -67,4 +68,5 @@ subjects:
- kind: ServiceAccount
name: "{{ template "pulsar.fullname" . }}-{{ .Values.functions.component }}"
namespace: {{ template "pulsar.namespace" . }}
{{- end }}
{{- end }}
2 changes: 1 addition & 1 deletion charts/pulsar/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@ functions:
component: functions-worker
useBookieAsStateStore: false
## Pulsar: Functions Worker ClusterRole or Role
## templates/broker-rbac.yaml
## templates/function-worker-rbac.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current Pulsar Helm Chart, there isn't a separate function-worker pod. The function-worker role is handled by the broker. Perhaps we should rename the file to be broker-function-worker-rbac.yaml to indicate this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess that would be the best solution. will do so.

# Default is false which deploys functions with ClusterRole and ClusterRoleBinding at the cluster level
# Set to true to deploy functions with Role and RoleBinding inside the specified namespace
rbac:
Expand Down
Loading