rename broker-rbac.yaml to function-worker-rbac.yaml #452
Conversation
| @@ -17,6 +17,7 @@ | |||
| # under the License. | |||
| # | |||
|
|
|||
| {{- if .Values.rbac.enabled }} | |||
There was a problem hiding this comment.
Adding this condition will break Pulsar Functions support. It is mandatory when .Values.components.functions is enabled. That's why adding this condition is problematic. Perhaps we instead need to clarify the documentation of rbac.enabled and explain that RBAC will be always configured for Pulsar Functions regardless of rbac.enabled.
There was a problem hiding this comment.
Ok. I will remove it from this PR.
charts/pulsar/values.yaml
Outdated
| @@ -930,7 +930,7 @@ functions: | |||
| component: functions-worker | |||
| useBookieAsStateStore: false | |||
| ## Pulsar: Functions Worker ClusterRole or Role | |||
| ## templates/broker-rbac.yaml | |||
| ## templates/function-worker-rbac.yaml | |||
There was a problem hiding this comment.
In the current Pulsar Helm Chart, there isn't a separate function-worker pod. The function-worker role is handled by the broker. Perhaps we should rename the file to be broker-function-worker-rbac.yaml to indicate this?
There was a problem hiding this comment.
i guess that would be the best solution. will do so.
Fixes #426
Motivation
Motivated by naming files accordingly to what they do.
Modifications
Rename files.
Verifying this change