Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(services/aliyun-drive): list dir without trailing slash #4766

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix(services/aliyun-drive): list dir without trailing slash #4766

merged 1 commit into from
Jun 19, 2024

Conversation

yuchanns
Copy link
Member

@yuchanns yuchanns commented Jun 19, 2024 •
edited
Loading

Pending.

I found that CI for AliyunDrive randomly failed. Investigating.

  • Fix AliyunDrive tests against behavior::test_list_dir_with_recursive_no_trailing_slash

@yuchanns yuchanns force-pushed the fix-aliyun-drive-list-no-trailing-slash branch from 062c64e to 7a17b98 Compare June 19, 2024 03:22
@yuchanns yuchanns marked this pull request as ready for review June 19, 2024 03:32
@yuchanns yuchanns requested a review from Xuanwo as a code owner June 19, 2024 03:32
@yuchanns
Copy link
Member Author

Hi @Xuanwo, I wonder why the PR skipped AliyunDrive CI. I can't test it lol.

@yuchanns yuchanns marked this pull request as draft June 19, 2024 03:37
@yuchanns yuchanns force-pushed the fix-aliyun-drive-list-no-trailing-slash branch from 7a17b98 to fe5aaa8 Compare June 19, 2024 03:38
@Xuanwo
Copy link
Member

Xuanwo commented Jun 19, 2024 •
edited
Loading

Hi @Xuanwo, I wonder why the PR skipped AliyunDrive CI. I can't test it lol.

PRs from forked repo can't access our secrets for security reasons: https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow

@yuchanns
Copy link
Member Author

OK. I'll close this PR and ask @suyanhanx for patch help.

@yuchanns yuchanns closed this Jun 19, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Jun 19, 2024

OK. I'll close this PR and ask @suyanhanx for patch help.

Please keep this PR open and allow @suyanhanx to open a new PR specifically for testing. I want to ensure your contributions are recognized in our repository.

@Xuanwo Xuanwo reopened this Jun 19, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Jun 19, 2024

Thanks @suyanhanx for conducting the test. All checks on the Aliyun drive have now passed, let's go ahead and merge!

@Xuanwo Xuanwo marked this pull request as ready for review June 19, 2024 04:23
Xuanwo
Xuanwo approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit c8d33a4 into apache:main Jun 19, 2024
145 checks passed
@yuchanns
Copy link
Member Author

It looks good on #4767 tests. While AliyunDrive severely restricts concurrency access per account. Core-Test, Binding-Python, and Binding-Java consist of three parallel on one account leads to many retries.

@yuchanns yuchanns deleted the fix-aliyun-drive-list-no-trailing-slash branch June 19, 2024 04:24
@yuchanns yuchanns mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@oowl oowl Awaiting requested review from oowl

@Young-Flash Young-Flash Awaiting requested review from Young-Flash

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@morristai morristai Awaiting requested review from morristai

Assignees
No one assigned
Labels
releases-note/fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuchanns @Xuanwo