-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Aliyun Drive Test failed #4764
Comments
Reading data at 4K doesn't make sense: 2024-06-18T15:04:32.588102Z TRACE opendal::services: service=aliyun_drive operation=Reader::read path=07367cad-8f97-4e24-a75c-19c507944a55 read=154902 -> read returns 4096B
at src/layers/logging.rs:986
2024-06-18T15:04:32.591711Z TRACE opendal::services: service=aliyun_drive operation=Reader::read path=07367cad-8f97-4e24-a75c-19c507944a55 read=158998 -> read returns 4096B
at src/layers/logging.rs:986 Maybe aliyun drive is too slow to test from us-east-1. This read is about 1.1KiB/s. |
We will also hit errors like: > operator.read(f"{parent}/{path}")
E opendal.UnexpectedError: RateLimited (persistent) at stat, context: { service: aliyun_drive, path: random_dir_86b5bcca-098d-4190-9511-2b92cd912490/x/x/y } => 请求过快,请等待 x-retry-after 毫秒后再请求 |
Hello @yuchanns and @suyanhanx, thank you for your efforts in bringing the Aliyun Drive integration test online. However, it consistently fails on our main branch. The primary issue seems to be that our CI runs in us-east-1, while Aliyun Drive is located in mainland China. I propose we disable this test until we can resolve the issue. What are your thoughts? |
How about disabling aliyun_drive test on bindings? cc @suyanhanx |
SGTM |
We can remove aliyun drive from the binding's planner. Would you like to create a PR for this? |
Aliyun has had a limitation of speed on non-VIP accounts recently. |
I'll do this. |
I propose optional splittable credentials for binding tests since the limit is per account. Besides, there may be other services encountering such limitations in the future. |
Well, it's much harder... All our services use the same setup and configuration. Allowing splittable credentials for services adds significant complexity to our current CI system. |
A quick glance: |
Good news, the aliyun drive test seems much stable now (passed in previous twice without retry!) |
Yes. Previously before #4766, there was a logical error I misunderstood about list behavior. It is hard to understand why it passed tests, especially on one thread. |
Cool, we can watch this test for sometime. We can keep the binding tests if it's stable for a while. |
Opened a PR #4770 that disabled the test aliyun_drive on bindings temporarily. |
Thank you all, now aliyun tests work well! |
https://github.com/apache/opendal/actions/runs/9566562882/job/26372216975
The text was updated successfully, but these errors were encountered: