DroneCAN add socketcan support, rename to DroneCAN #1558
Conversation
PetervdPerk-NXP
force-pushed
the
dronecan_update
branch
2 times, most recently
from
6279d6b
to
ab43cf9
Compare
PetervdPerk-NXP
force-pushed
the
dronecan_update
branch
from
ab43cf9
to
28980b3
Compare
|
ping @xiaoxiang781216 |
| LIBDRONECAN_UNPACKNAME = libcanard-$(LIBDRONECAN_VERSION) | ||
| LIBDRONECAN_SRCNAME = libcanard | ||
|
|
||
| LIBDRONECAN_SRCDIR = $(WD)/$(LIBDRONECAN_SRCNAME) |
| ifeq ($(wildcard $(LIBDRONECAN_SRCNAME)/.git),) | ||
| $(LIBDRONECAN_PACKNAME): | ||
| @echo "Downloading: $@" | ||
| $(Q) curl -o $@ -L $(LIBDRONECAN_URL)$(DELIM)$(LIBDRONECAN_VERSION)$(PACKEXT) |
There was a problem hiding this comment.
use DOWNLOAD macro
There was a problem hiding this comment.
I may have missed something, but where's this new DOWNLOAD macro documented?
There was a problem hiding this comment.
Please reference: apache/nuttx#8759
| $(Q) mv $(LIBDRONECAN_UNPACKNAME) $(LIBDRONECAN_SRCNAME) | ||
| $(Q) touch $@ | ||
|
|
||
| $(LIBDRONECAN_SRCDIR)$(DELIM)canard.c: $(LIBDRONECAN_SRCNAME) |
There was a problem hiding this comment.
why need this rule
PetervdPerk-NXP
force-pushed
the
dronecan_update
branch
from
28980b3
to
a51626b
Compare
|
I'm by all means not really comfortable with Makefile. So I don't want to spend more to time to fine tune this further. Most of the things in this file are derived from existing in the upstream Makefiles i.e. nuttx-apps/canutils/lely-canopen/Makefile Line 27 in f3c104b nuttx-apps/crypto/mbedtls/Makefile Line 51 in f3c104b nuttx-apps/canutils/libcanardv0/Makefile Line 54 in f3c104b I've tested it with upstream NuttX, with both libraries and the combinations of them. |
PetervdPerk-NXP
force-pushed
the
dronecan_update
branch
from
23b1bf3
to
4c7c169
Compare
|
@PetervdPerk-NXP do you provide the patch to fix nuttx side? |
|
No changes needed on NuttX side |
|
but the ci fail. |
Rename canardv1 to OpenCyphal Apply suggestions from code review Co-authored-by: Petro Karashchenko <[email protected]>
PetervdPerk-NXP
force-pushed
the
dronecan_update
branch
from
4c7c169
to
0b2953b
Compare
|
@xiaoxiang781216 |
|
Hi I'm a bit lost on what to do get this PR and apache/nuttx#8967 into upstream? Any suggestion to progress further? |
|
@PetervdPerk-NXP unfortunately we don't have a clean way to run CI against cross-coupled changes. I had a few ideas in the past, but never had time to try and implement them. For now we rely on local testing and then merging both (usually I merge app first). Then if CI on master breaks we try to get a quick fix merge in, or just revert the changes. Not ideal I know.... Maybe I will be inspired back from vacation to do the work. |
|
@PetervdPerk-NXP let me merge both patch and fix the ci possible broken in the next couple hours. |
Summary
Rename libcanardv0 library to libdronecan to avoid confusion and update the DroneCAN libcanard library.
Furthermore add SocketCAN backend support to both DroneCAN and the example application.
CAN FD is supported but should be considered experimental.
Furthermore renames libcanardv1 to libopencyphal and allows co-existance of DroneCAN and OpenCyphal Cyphal/CAN.