Apply suggestions from code review

Co-authored-by: Petro Karashchenko <[email protected]>
apache · Mar 20, 2023 · 23b1bf3 · 23b1bf3
1 parent a51626b
commit 23b1bf3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/canutils/libdronecan/Make.defs b/canutils/libdronecan/Make.defs
@@ -21,7 +21,6 @@
 ifneq ($(CONFIG_CANUTILS_LIBDRONECAN),)
 CONFIGURED_APPS += $(APPDIR)/canutils/libdronecan
 
-
 ifeq ($(CONFIG_NET_CAN),y)
 CFLAGS += ${INCDIR_PREFIX}$(APPDIR)/canutils/libdronecan/libcanard/drivers/socketcan
 CXXFLAGS += ${INCDIR_PREFIX}$(APPDIR)/canutils/libdronecan/libcanard/drivers/socketcan

diff --git a/canutils/libopencyphal/Make.defs b/canutils/libopencyphal/Make.defs
@@ -21,7 +21,6 @@
 ifneq ($(CONFIG_CANUTILS_LIBOPENCYPHAL),)
 CONFIGURED_APPS += $(APPDIR)/canutils/libopencyphal
 
-
 CFLAGS += ${INCDIR_PREFIX}$(APPDIR)/canutils/libopencyphal/o1heap/o1heap
 CXXFLAGS += ${INCDIR_PREFIX}$(APPDIR)/canutils/libopencyphal/o1heap/o1heap
 

diff --git a/examples/dronecan/canard_main.c b/examples/dronecan/canard_main.c
@@ -126,7 +126,7 @@ static uint8_t node_mode = UAVCAN_NODE_MODE_INITIALIZATION;
 static bool g_canard_daemon_started;
 
 #if CANARD_ENABLE_CANFD
-static bool canfd = false;
+static bool canfd;
 #endif
 
 /****************************************************************************
@@ -250,7 +250,7 @@ static void onTransferReceived(CanardInstance *ins,
                                transfer->priority,
                                CanardResponse,
                                &buffer[0],
-                               (uint16_t) total_size, canfd);
+                               (uint16_t)total_size, canfd);
 #else
         canardRequestOrRespond(ins,
                                transfer->source_node_id,
@@ -415,9 +415,9 @@ void process1HzTasks(uint64_t timestamp_usec)
  *
  ****************************************************************************/
 #ifdef CONFIG_NET_CAN
-void processTxRxOnce(SocketCANInstance  * socketcan, int timeout_msec)
+void processTxRxOnce(SocketCANInstance *socketcan, int timeout_msec)
 #else
-void processTxRxOnce(CanardNuttXInstance * nuttxcan, int timeout_msec)
+void processTxRxOnce(CanardNuttXInstance *nuttxcan, int timeout_msec)
 #endif
 {
   const CanardCANFrame *txf;
@@ -501,7 +501,7 @@ static int canard_daemon(int argc, char *argv[])
 
 
 #ifdef CONFIG_NET_CAN
-  const char *const can_iface_name = "can0";
+  const char * const can_iface_name = "can0";
 
 #  if CANARD_ENABLE_CANFD
   int16_t res = socketcanInit(&socketcan, can_iface_name, canfd);
@@ -604,7 +604,8 @@ int main(int argc, FAR char *argv[])
       return EXIT_SUCCESS;
     }
 
-  if (argc == 2 && strcmp(argv[1],"canfd") == 0) {
+  if (argc == 2 && strcmp(argv[1], "canfd") == 0)
+    {
       printf("CAN FD mode enabled\n");
       canfd = true;
   }