Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nimble/host: Add Broadcast Audio Scan Service #1691

Merged
merged 1 commit into from
Apr 29, 2024
Merged

nimble/host: Add Broadcast Audio Scan Service #1691

merged 1 commit into from
Apr 29, 2024

Conversation

KKopyscinski
Copy link
Contributor

BASS initial implementation

MariuszSkamra
MariuszSkamra suggested changes Feb 27, 2024
View reviewed changes
nimble/host/services/audio/bass/include/services/bass/ble_audio_svc_bass.h Outdated Show resolved Hide resolved
nimble/host/services/audio/bass/include/services/bass/ble_audio_svc_bass.h Outdated Show resolved Hide resolved
nimble/host/services/audio/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
nimble/host/services/audio/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
nimble/host/services/audio/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
nimble/host/services/audio/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
nimble/host/services/audio/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
nimble/host/services/audio/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
nimble/host/services/audio/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
nimble/host/services/audio/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
@KKopyscinski KKopyscinski force-pushed the bass branch 2 times, most recently from 3c6aa65 to a7c84ed Compare March 12, 2024 08:47
@KKopyscinski KKopyscinski marked this pull request as ready for review March 12, 2024 08:55
@KKopyscinski KKopyscinski force-pushed the bass branch 3 times, most recently from 2bc5bf2 to 84a6111 Compare March 12, 2024 09:12
@MariuszSkamra MariuszSkamra mentioned this pull request Mar 14, 2024
Merged
@KKopyscinski KKopyscinski force-pushed the bass branch 7 times, most recently from 4165900 to b6f1be7 Compare March 25, 2024 08:32
@KKopyscinski KKopyscinski force-pushed the bass branch 5 times, most recently from 28d771f to b058658 Compare April 22, 2024 11:44
MariuszSkamra
MariuszSkamra reviewed Apr 23, 2024
View reviewed changes
nimble/host/audio/include/audio/ble_audio.h Outdated Show resolved Hide resolved
nimble/host/audio/include/audio/ble_audio.h Outdated Show resolved Hide resolved
nimble/host/audio/include/audio/ble_audio.h Outdated Show resolved Hide resolved
nimble/host/audio/include/audio/ble_audio.h Outdated Show resolved Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h Show resolved Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h Show resolved Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h Show resolved Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h Outdated Show resolved Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h Show resolved Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h Show resolved Hide resolved
@KKopyscinski KKopyscinski force-pushed the bass branch 3 times, most recently from 1aa22e9 to 1b013d3 Compare April 23, 2024 11:48
MariuszSkamra
MariuszSkamra suggested changes Apr 26, 2024
View reviewed changes
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h Outdated Show resolved Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h Outdated Show resolved Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h Outdated Show resolved Hide resolved
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h Outdated Show resolved Hide resolved
nimble/host/audio/services/bass/include/services/bass/ble_audio_svc_bass.h Show resolved Hide resolved
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
nimble/host/audio/services/bass/src/ble_audio_svc_bass.c Outdated Show resolved Hide resolved
@KKopyscinski KKopyscinski force-pushed the bass branch 7 times, most recently from 551220d to ffeaffa Compare April 26, 2024 10:51
MariuszSkamra
MariuszSkamra approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@MariuszSkamra MariuszSkamra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KKopyscinski KKopyscinski merged commit 4ebbbf2 into apache:master Apr 29, 2024
18 checks passed
@KKopyscinski KKopyscinski deleted the bass branch April 29, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariuszSkamra MariuszSkamra MariuszSkamra approved these changes

@rymanluk rymanluk Awaiting requested review from rymanluk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KKopyscinski @rymanluk @MariuszSkamra