nimble/audio: Add Audio Broadcast Sink initial implementation #1677

MariuszSkamra · 2024-01-22T19:30:55Z

Depends on: #1691

nimble/host/src/ble_iso.c

nimble/host/audio/src/ble_audio_bsnk.c

KKopyscinski · 2024-02-08T07:25:59Z

nimble/host/src/ble_hs_hci_evt.c

 static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_create_big_complete;
 static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_terminate_big_complete;
 #endif
+#if MYNEWT_VAL(BLE_ISO_BROADCAST_SINK)
+static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_big_sync_extablished;


Suggested change

static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_big_sync_extablished;

static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_big_sync_established;

typo :)

KKopyscinski · 2024-02-08T07:59:06Z

nimble/host/audio/include/host/audio/ble_audio.h

+    enum ble_audio_bsnk_sync_state state;
+
+    /** BIS Synchronization */
+    uint32_t bis_sync;


I think this should be an array - probably pointer with count of entries (subgroups)

apps/btshell/src/cmd_leaudio.c

KKopyscinski · 2024-04-22T05:10:35Z

nimble/host/audio/include/audio/ble_audio.h

@@ -536,17 +536,8 @@ struct ble_audio_broadcast_name {
 /** BLE Audio event: BASS - Remote Scan Started */
 #define BLE_AUDIO_EVENT_BASS_REMOTE_SCAN_STARTED             4

-/** BLE Audio event: BASS - Add Source */


What's the reason to remove these events? I guess the upper layer knows that some actions were performed because the action callback will be called, but this callback is not mandatory. So if the operation was accepted autonomously, there will be no feedback for upper layer/app. For example, we could never enter here:
e5a346b#diff-b8c009ce2010b2473424d883cd93e8fe365b1c1af565ad8ba875280fd069133cR324

not applicable

rymanluk · 2024-05-16T07:13:53Z

nimble/host/audio/include/audio/ble_audio_broadcast_sink.h

+            uint32_t presentation_delay;
+
+            /** Pointer to Maximum Subevents value to initialize. */
+            uint8_t *out_mse;


We should add NSE and BN here so application has any means to choose out_MSE.

Also we should set default to 0x00 which means controller can choose up to NSE

rymanluk · 2024-05-16T07:14:22Z

nimble/host/audio/include/audio/ble_audio_broadcast_sink.h

+            uint8_t *out_mse;
+
+            /** Pointer to Sync Timeout value to initialize. */
+            uint16_t *out_sync_timeout;


Lets add comment about minimum and also set default here:

BIG_Sync_Timeout set by the Host is less than 6 × ISO_Interval, the Controller shall set the timeout to 6 × ISO_Interval

This adds initial implementation of audio broadcast sink.

this extends the btshell application with Audio Broadcast Sink functionality.

This enables PACS when Broadcast Sink role is enabled. By default the 16_2 and 24_2 mandatory settings are supported as per spec.

MariuszSkamra · 2024-05-24T10:23:27Z

Fixed missing ble_audio_scan_delegator_receive_state_set call in bass_pa_state_update

szymon-czapracki · 2024-06-27T09:56:30Z

nimble/host/audio/src/ble_audio_broadcast_sink.c

+
+    rc = ble_iso_big_sync_create(&big_sync_create_params, &sink->big_handle);
+    if (rc != 0) {
+        BLE_HS_LOG_ERROR("big sync failed (%d)\n", rc);


Shouldn't there also be big_sync_state_set(sink, BIG_SYNC_STGATE_FAILED) ?

rymanluk

LGTM

MariuszSkamra force-pushed the broadcast_sink branch 6 times, most recently from 40bc8f0 to 5746199 Compare January 26, 2024 15:24

MariuszSkamra changed the title ~~[WIP] nimble/audio: Add Audio Broadcast Sink initial implementation~~ nimble/audio: Add Audio Broadcast Sink initial implementation Jan 26, 2024

github-advanced-security bot found potential problems Jan 29, 2024

View reviewed changes

nimble/host/src/ble_iso.c Fixed Show fixed Hide fixed

KKopyscinski reviewed Feb 2, 2024

View reviewed changes

nimble/host/audio/src/ble_audio_bsnk.c Outdated Show resolved Hide resolved

KKopyscinski reviewed Feb 8, 2024

View reviewed changes

MariuszSkamra force-pushed the broadcast_sink branch from 5746199 to 048498a Compare March 5, 2024 09:40

MariuszSkamra force-pushed the broadcast_sink branch from 048498a to 8279cae Compare March 14, 2024 09:58

MariuszSkamra commented Mar 18, 2024

View reviewed changes

apps/btshell/src/cmd_leaudio.c Outdated Show resolved Hide resolved

MariuszSkamra force-pushed the broadcast_sink branch 3 times, most recently from 0b4efd2 to e5fec9e Compare April 21, 2024 22:49

KKopyscinski reviewed Apr 22, 2024

View reviewed changes

MariuszSkamra force-pushed the broadcast_sink branch 11 times, most recently from 31b2fb7 to e344999 Compare April 29, 2024 07:19

MariuszSkamra force-pushed the broadcast_sink branch from e344999 to cc423ad Compare April 30, 2024 06:17

MariuszSkamra force-pushed the broadcast_sink branch 2 times, most recently from 3c15b4e to dcbc798 Compare April 30, 2024 07:02

MariuszSkamra marked this pull request as ready for review April 30, 2024 13:48

MariuszSkamra force-pushed the broadcast_sink branch from dcbc798 to 255892f Compare May 15, 2024 12:55

rymanluk reviewed May 16, 2024

View reviewed changes

MariuszSkamra force-pushed the broadcast_sink branch 2 times, most recently from ea5fd34 to d65b611 Compare May 17, 2024 06:42

MariuszSkamra added 3 commits May 24, 2024 12:22

nimble/audio: Add initial audio broadcast sink implementation

04ca186

This adds initial implementation of audio broadcast sink.

apps/btshell: Add Audio Broadcast Sink to shell application

3ae79ef

this extends the btshell application with Audio Broadcast Sink functionality.

nimble/audio: Add PACS to Broadcast Sink

218617d

This enables PACS when Broadcast Sink role is enabled. By default the 16_2 and 24_2 mandatory settings are supported as per spec.

MariuszSkamra force-pushed the broadcast_sink branch from d65b611 to 218617d Compare May 24, 2024 10:22

szymon-czapracki reviewed Jun 27, 2024

View reviewed changes

rymanluk approved these changes Jul 1, 2024

View reviewed changes

rymanluk merged commit 0602660 into apache:master Jul 1, 2024

MariuszSkamra deleted the broadcast_sink branch July 2, 2024 06:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nimble/audio: Add Audio Broadcast Sink initial implementation #1677

nimble/audio: Add Audio Broadcast Sink initial implementation #1677

MariuszSkamra commented Jan 22, 2024 •

edited

Loading

KKopyscinski Feb 8, 2024 •

edited

Loading

MariuszSkamra May 16, 2024

KKopyscinski Feb 8, 2024

MariuszSkamra Apr 21, 2024

KKopyscinski Apr 22, 2024

MariuszSkamra May 16, 2024

rymanluk May 16, 2024

MariuszSkamra May 16, 2024

rymanluk May 16, 2024

MariuszSkamra May 16, 2024

MariuszSkamra commented May 24, 2024 •

edited

Loading

szymon-czapracki Jun 27, 2024

rymanluk left a comment

	static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_big_sync_extablished;
	static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_big_sync_established;

nimble/audio: Add Audio Broadcast Sink initial implementation #1677

nimble/audio: Add Audio Broadcast Sink initial implementation #1677

Conversation

MariuszSkamra commented Jan 22, 2024 • edited Loading

KKopyscinski Feb 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MariuszSkamra commented May 24, 2024 • edited Loading

Choose a reason for hiding this comment

rymanluk left a comment

Choose a reason for hiding this comment

MariuszSkamra commented Jan 22, 2024 •

edited

Loading

KKopyscinski Feb 8, 2024 •

edited

Loading

MariuszSkamra commented May 24, 2024 •

edited

Loading