[RSPEC-S1068] Remove unused private fields
#2317
Draft
+0
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraz76
commented
May 10, 2025
| @@ -43,8 +43,6 @@ public final class CLIReportingUtils { | |||
| private static final long ONE_MINUTE = 60 * ONE_SECOND; | |||
|
|
|||
| private static final long ONE_HOUR = 60 * ONE_MINUTE; | |||
|
|
|||
| private static final long ONE_DAY = 24 * ONE_HOUR; | |||
There was a problem hiding this comment.
this might be API but seems unused
There was a problem hiding this comment.
Want to investigate, what its actually used for.
Pankraz76
force-pushed
the
RemoveUnusedPrivateFields
branch
from
f1dbef5 to
1c1a395
Compare
Pankraz76
commented
May 10, 2025
|
|
||
| private static final long ONE_MINUTE = 60 * ONE_SECOND; | ||
|
|
||
| private static final long ONE_HOUR = 60 * ONE_MINUTE; |
There was a problem hiding this comment.
- Private field 'ONE_HOUR' is never used openrewrite/rewrite-static-analysis#554
assuming circle issue as last block item was found.ONE_DAY
|
SUCCESS 
|
|
kindly request some feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[RSPEC-S1068] Remove
unusedprivate fields