RemoveUnusedPrivateFields

Author: Vincent Potucek

compat/maven-model-builder/src/main/java/org/apache/maven/utils/Os.java

@@ -128,11 +128,6 @@ public class Os {
      */
     private static final String DARWIN = "darwin";
 
-    /**
-     * The path separator.
-     */
-    private static final String PATH_SEP = System.getProperty("path.separator");
-
     static {
         // Those two public constants are initialized here, as they need all the private constants
         // above to be initialized first, but the code style imposes the public constants to be

impl/maven-cli/src/main/java/org/apache/maven/cling/utils/CLIReportingUtils.java

@@ -35,17 +35,6 @@
  *
  */
 public final class CLIReportingUtils {
-    // CHECKSTYLE_OFF: MagicNumber
-    public static final long MB = 1024 * 1024;
-
-    private static final long ONE_SECOND = 1000L;
-
-    private static final long ONE_MINUTE = 60 * ONE_SECOND;
-
-    private static final long ONE_HOUR = 60 * ONE_MINUTE;
-
-    private static final long ONE_DAY = 24 * ONE_HOUR;
-    // CHECKSTYLE_ON: MagicNumber
 
     public static final String BUILD_VERSION_PROPERTY = "version";
 

impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java

@@ -131,7 +131,6 @@ public class DefaultModelBuilder implements ModelBuilder {
     private static final String FILE = "file";
     private static final String IMPORT = "import";
     private static final String PARENT = "parent";
-    private static final String MODEL = "model";
 
     private final Logger logger = LoggerFactory.getLogger(getClass());
 

its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6401ProxyPortInterpolationTest.java

@@ -28,10 +28,6 @@
 
 class MavenITmng6401ProxyPortInterpolationTest extends AbstractMavenIntegrationTestCase {
 
-    private Proxy proxy;
-
-    private int port;
-
     protected MavenITmng6401ProxyPortInterpolationTest() {
         super("(4.0.0-alpha-7,)");
     }

its/core-it-suite/src/test/resources/mng-3259/module5/src/main/java/mng/Module5.java

@@ -19,5 +19,4 @@
 package mng;
 
 public class Module5 {
-    private Module4 m4;
 }

its/core-it-suite/src/test/resources/mng-3694/maven-mng3694-plugin/src/main/java/plugin/MyMojo.java

@@ -47,24 +47,12 @@
  */
 public class MyMojo extends AbstractMojo {
 
-    /**
-     * Not used, just an offset to place reactorProjects in the middle.
-     * @parameter default-value="${project.build.directory}"
-     */
-    private String outputDirectory;
-
     /**
      * @parameter expression="${reactorProjects}"
      * @required
      */
     private List reactorProjects;
 
-    /**
-     * Not used, just an offset to place reactorProjects in the middle.
-     * @parameter default-value="${project.build.directory}"
-     */
-    private String outputDirectory2;
-
     public void execute() throws MojoExecutionException {
         for (Iterator it = reactorProjects.iterator(); it.hasNext(); ) {
             MavenProject project = (MavenProject) it.next();