[Fix](job)Fix CAS competition failure leading to message publishing failure. #45018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
morrySnow
previously approved these changes
Dec 5, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
run feut |
…ailure. tryPublish returns false in case of CAS competition failure or when the queue is full. Therefore, we need to first check if there is enough capacity and then use the publish method for serial publishing.
CalvinKirs
force-pushed
the
master-disruptor-sizes
branch
from
d638637 to
85028e2
Compare
github-actions
bot
removed
the
approved
|
run buildall |
CalvinKirs
force-pushed
the
master-disruptor-sizes
branch
from
dc477f9 to
f7e26af
Compare
|
run buildall |
JNSimba
approved these changes
Dec 5, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
…ailure. (#45018) ### What problem does this PR solve? **tryPublish** returns false in case of CAS competition failure or when the queue is full. Therefore, we need to first check if there is enough capacity and then use the **publish** method for serial publishing.
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
…ailure. (#45018) ### What problem does this PR solve? **tryPublish** returns false in case of CAS competition failure or when the queue is full. Therefore, we need to first check if there is enough capacity and then use the **publish** method for serial publishing.
yiguolei
pushed a commit
that referenced
this pull request
Dec 6, 2024
…publishing failure. #45018 (#45030) Cherry-picked from #45018 Co-authored-by: Calvin Kirs <[email protected]>
morningman
pushed a commit
that referenced
this pull request
Dec 8, 2024
…publishing failure. #45018 (#45029) Cherry-picked from #45018 Co-authored-by: Calvin Kirs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
tryPublish returns false in case of CAS competition failure or when the queue is full. Therefore, we need to first check if there is enough capacity and then use the publish method for serial publishing.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)