Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch-3.0: [Fix](job)Fix CAS competition failure leading to message publishing failure. #45018 #45029

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 5, 2024

Cherry-picked from #45018

…ailure. (#45018)

### What problem does this PR solve?

**tryPublish** returns false in case of CAS competition failure or when
the queue is full. Therefore, we need to first check if there is enough
capacity and then use the **publish** method for serial publishing.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Dec 5, 2024
@dataroaring dataroaring reopened this Dec 5, 2024
@doris-robot
Copy link

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40400 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5d6edbc61ebbb8f6dbf6d2ea38784f7b258ad035, data reload: false

------ Round 1 ----------------------------------
q1	17574	7430	7224	7224
q2	2065	173	179	173
q3	10669	1346	1096	1096
q4	10562	767	739	739
q5	7756	2783	2749	2749
q6	234	149	149	149
q7	965	631	607	607
q8	9587	1900	1962	1900
q9	7949	6393	6375	6375
q10	7006	2254	2295	2254
q11	455	254	259	254
q12	400	221	216	216
q13	17782	2962	2971	2962
q14	233	212	210	210
q15	557	525	522	522
q16	692	613	599	599
q17	960	571	591	571
q18	7222	6581	6621	6581
q19	1373	1020	1058	1020
q20	463	199	201	199
q21	3913	3308	3049	3049
q22	1068	962	951	951
Total cold run time: 109485 ms
Total hot run time: 40400 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7303	7186	7197	7186
q2	326	233	223	223
q3	2905	2875	2858	2858
q4	2019	1807	1738	1738
q5	5657	5680	5677	5677
q6	229	144	143	143
q7	2147	1793	1801	1793
q8	3314	3551	3408	3408
q9	8825	8834	8785	8785
q10	3537	3536	3492	3492
q11	602	494	489	489
q12	829	608	624	608
q13	16010	3109	3163	3109
q14	310	269	276	269
q15	568	512	522	512
q16	701	667	683	667
q17	1830	1614	1589	1589
q18	8181	7741	7327	7327
q19	5228	1502	1560	1502
q20	2067	1842	1839	1839
q21	5346	5225	5237	5225
q22	1102	985	1011	985
Total cold run time: 79036 ms
Total hot run time: 59424 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196330 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5d6edbc61ebbb8f6dbf6d2ea38784f7b258ad035, data reload: false

query1	1234	922	921	921
query2	6255	2149	2033	2033
query3	10830	4103	4035	4035
query4	66769	27021	23515	23515
query5	5306	476	444	444
query6	503	190	183	183
query7	6136	311	316	311
query8	336	237	231	231
query9	9524	2680	2666	2666
query10	489	247	259	247
query11	17599	15213	15910	15213
query12	163	98	100	98
query13	1568	429	415	415
query14	11425	7408	7432	7408
query15	212	176	173	173
query16	7086	502	478	478
query17	1323	584	610	584
query18	1794	335	322	322
query19	198	160	159	159
query20	120	112	107	107
query21	210	104	107	104
query22	4532	4581	4508	4508
query23	34613	34002	34069	34002
query24	5803	2920	2904	2904
query25	542	425	423	423
query26	662	176	169	169
query27	1734	300	308	300
query28	4517	2593	2550	2550
query29	706	464	442	442
query30	245	179	189	179
query31	1029	843	851	843
query32	65	60	55	55
query33	412	286	292	286
query34	906	510	547	510
query35	868	770	747	747
query36	1077	917	938	917
query37	115	68	70	68
query38	4104	4001	4005	4001
query39	1561	1472	1469	1469
query40	204	98	101	98
query41	51	46	45	45
query42	126	99	102	99
query43	519	503	487	487
query44	1174	807	817	807
query45	185	169	167	167
query46	1158	727	756	727
query47	1960	1892	1869	1869
query48	471	379	389	379
query49	706	402	381	381
query50	832	432	420	420
query51	7345	7153	7010	7010
query52	93	93	87	87
query53	273	186	184	184
query54	588	447	439	439
query55	74	76	72	72
query56	243	225	223	223
query57	1178	1077	1090	1077
query58	205	201	197	197
query59	3091	2849	2769	2769
query60	278	241	234	234
query61	107	102	104	102
query62	786	658	649	649
query63	211	199	196	196
query64	1431	643	616	616
query65	3261	3155	3197	3155
query66	632	292	307	292
query67	15606	15237	15345	15237
query68	4531	547	543	543
query69	460	252	253	252
query70	1063	1078	1136	1078
query71	398	251	256	251
query72	6479	4041	3940	3940
query73	763	342	337	337
query74	9890	8947	9043	8947
query75	3345	2649	2675	2649
query76	2277	1018	1079	1018
query77	531	282	282	282
query78	10862	9727	9708	9708
query79	8666	601	596	596
query80	2130	434	433	433
query81	549	241	238	238
query82	1034	114	112	112
query83	264	138	148	138
query84	285	78	79	78
query85	1690	310	280	280
query86	482	290	296	290
query87	4611	4181	4155	4155
query88	5728	2346	2372	2346
query89	550	284	290	284
query90	2179	183	184	183
query91	203	141	145	141
query92	62	48	46	46
query93	6545	544	545	544
query94	902	284	293	284
query95	339	245	241	241
query96	629	270	274	270
query97	3359	3138	3147	3138
query98	228	198	197	197
query99	1611	1293	1299	1293
Total cold run time: 338004 ms
Total hot run time: 196330 ms

@morningman morningman merged commit bdd5e95 into branch-3.0 Dec 8, 2024
19 of 21 checks passed
@github-actions github-actions bot deleted the auto-pick-45018-branch-3.0 branch December 8, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants