Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test](nereids) add test simplify comparison predicate #44886

Merged
merged 5 commits into from
Dec 23, 2024
Merged

[test](nereids) add test simplify comparison predicate #44886

merged 5 commits into from
Dec 23, 2024

Conversation

yujun777
Copy link
Collaborator

@yujun777 yujun777 commented Dec 3, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Add test simplify comparison predicate

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777 yujun777 marked this pull request as draft December 3, 2024 01:42
@yujun777
Copy link
Collaborator Author

yujun777 commented Dec 3, 2024

when comparison with date like type still has bug, need fix them first

@yujun777 yujun777 force-pushed the test-simplify-comparison-predicate-2 branch from 77dce5f to 2a33bb3 Compare December 23, 2024 01:58
@yujun777 yujun777 marked this pull request as ready for review December 23, 2024 03:03
@yujun777
Copy link
Collaborator Author

run buildall

@yujun777
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39778 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 654edea96c91108d83befda8859ae0828df44522, data reload: false

------ Round 1 ----------------------------------
q1	17596	7501	7245	7245
q2	2058	175	167	167
q3	10663	1065	1163	1065
q4	10589	753	788	753
q5	7620	2729	2745	2729
q6	241	148	143	143
q7	988	623	629	623
q8	9266	1889	1967	1889
q9	6556	6381	6441	6381
q10	7006	2281	2317	2281
q11	467	256	260	256
q12	427	229	223	223
q13	17796	2882	2904	2882
q14	256	234	211	211
q15	563	513	497	497
q16	654	592	597	592
q17	984	569	526	526
q18	7464	6731	6800	6731
q19	1337	1004	1021	1004
q20	471	184	190	184
q21	3997	3280	3090	3090
q22	387	312	306	306
Total cold run time: 107386 ms
Total hot run time: 39778 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7248	7243	7177	7177
q2	325	230	235	230
q3	2930	2827	2955	2827
q4	2087	1821	1841	1821
q5	5651	5742	5684	5684
q6	234	142	142	142
q7	2262	1815	1793	1793
q8	3385	3537	3509	3509
q9	8769	8946	8969	8946
q10	3589	3569	3493	3493
q11	626	504	518	504
q12	852	596	610	596
q13	9489	3188	3048	3048
q14	307	281	274	274
q15	564	515	499	499
q16	685	653	656	653
q17	1876	1663	1614	1614
q18	8577	7755	7811	7755
q19	1746	1513	1625	1513
q20	2144	1840	1938	1840
q21	5527	5433	5348	5348
q22	628	578	577	577
Total cold run time: 69501 ms
Total hot run time: 59843 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196281 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 654edea96c91108d83befda8859ae0828df44522, data reload: false

query1	1294	946	937	937
query2	6253	2424	2370	2370
query3	10994	4672	4742	4672
query4	33135	23350	23295	23295
query5	4060	448	469	448
query6	292	182	191	182
query7	4011	303	329	303
query8	313	245	241	241
query9	9506	2702	2693	2693
query10	480	249	247	247
query11	17894	15085	15174	15085
query12	162	106	106	106
query13	1574	438	412	412
query14	10175	6733	6940	6733
query15	310	222	194	194
query16	8286	455	415	415
query17	1751	609	617	609
query18	2196	316	316	316
query19	372	198	158	158
query20	119	119	113	113
query21	207	118	104	104
query22	4784	4676	4822	4676
query23	34656	33867	33689	33689
query24	10358	2527	2525	2525
query25	609	436	430	430
query26	1152	156	155	155
query27	2753	331	329	329
query28	8112	2460	2494	2460
query29	824	418	421	418
query30	228	154	149	149
query31	1032	852	854	852
query32	106	58	55	55
query33	762	315	310	310
query34	1141	534	530	530
query35	904	757	781	757
query36	1093	971	990	971
query37	144	80	72	72
query38	4580	4107	4338	4107
query39	1496	1475	1482	1475
query40	209	99	104	99
query41	47	43	45	43
query42	118	105	105	105
query43	563	520	513	513
query44	1286	856	843	843
query45	187	167	168	167
query46	1180	730	724	724
query47	2044	1942	1907	1907
query48	418	325	323	323
query49	1018	393	379	379
query50	841	419	392	392
query51	7383	7264	7044	7044
query52	102	99	96	96
query53	264	184	186	184
query54	1044	411	418	411
query55	84	85	95	85
query56	263	238	251	238
query57	1297	1173	1165	1165
query58	238	222	229	222
query59	3366	3304	3146	3146
query60	267	264	252	252
query61	108	109	112	109
query62	868	692	704	692
query63	224	193	194	193
query64	4018	706	642	642
query65	3402	3205	3282	3205
query66	771	305	316	305
query67	16506	15700	15591	15591
query68	5170	549	558	549
query69	491	249	256	249
query70	1210	1122	1068	1068
query71	493	254	245	245
query72	6583	4147	4077	4077
query73	787	357	361	357
query74	10548	8894	8862	8862
query75	3632	2656	2638	2638
query76	3621	1015	1116	1015
query77	667	305	267	267
query78	10122	9669	9485	9485
query79	1890	602	605	602
query80	697	424	435	424
query81	502	235	227	227
query82	659	114	119	114
query83	166	154	144	144
query84	236	127	71	71
query85	1286	342	296	296
query86	435	301	293	293
query87	4843	4325	4376	4325
query88	3744	2223	2191	2191
query89	421	292	281	281
query90	2109	184	184	184
query91	199	106	106	106
query92	65	50	54	50
query93	1886	546	533	533
query94	825	288	286	286
query95	349	250	248	248
query96	617	272	282	272
query97	2890	2645	2663	2645
query98	223	195	197	195
query99	1542	1319	1314	1314
Total cold run time: 305142 ms
Total hot run time: 196281 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 654edea96c91108d83befda8859ae0828df44522, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.24	0.07	0.08
query4	1.60	0.11	0.11
query5	0.43	0.42	0.43
query6	1.14	0.66	0.64
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.50	0.51
query10	0.56	0.59	0.55
query11	0.15	0.11	0.10
query12	0.13	0.11	0.11
query13	0.60	0.59	0.60
query14	2.70	2.74	2.76
query15	0.89	0.82	0.82
query16	0.38	0.37	0.38
query17	1.11	1.04	1.04
query18	0.22	0.22	0.20
query19	1.94	1.76	1.99
query20	0.01	0.02	0.01
query21	15.36	0.60	0.58
query22	2.86	2.03	1.78
query23	17.01	0.94	0.92
query24	3.46	2.31	0.72
query25	0.26	0.17	0.13
query26	0.44	0.13	0.14
query27	0.05	0.03	0.04
query28	9.78	1.11	1.08
query29	12.62	3.27	3.24
query30	0.25	0.06	0.07
query31	2.86	0.39	0.38
query32	3.23	0.46	0.45
query33	3.02	3.01	3.12
query34	17.22	4.45	4.44
query35	4.48	4.40	4.40
query36	0.68	0.47	0.47
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.03
query40	0.17	0.13	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 106.91 s
Total hot run time: 32.27 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@englefly englefly merged commit e09bc04 into apache:master Dec 23, 2024
26 of 27 checks passed
This was referenced Dec 23, 2024
Merged
Merged
yiguolei pushed a commit that referenced this pull request Dec 24, 2024
@yujun777
branch-2.1: [test](nereids) add test simplify comparison predicate #4…
1314a2b 
…4886 (#45804)

cherry pick from #44886
yiguolei pushed a commit that referenced this pull request Dec 24, 2024
@yujun777
branch-3.0: [test](nereids) add test simplify comparison predicate #4…
fc2f65d 
…4886 (#45803)

cherry pick from #44886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@englefly englefly englefly approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yujun777 @doris-robot @englefly @starocean999 @yiguolei @morrySnow