Skip to content

Improved CI test coverage for rust features #15155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
alamb opened this issue Mar 11, 2025 · 4 comments · Fixed by #15203
Closed
1 of 3 tasks

Improved CI test coverage for rust features #15155

alamb opened this issue Mar 11, 2025 · 4 comments · Fixed by #15203
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Mar 11, 2025

Is your feature request related to a problem or challenge?

DataFusion has many rust features (e.g. --features=parquet) and recently we hit discovered several failures for features during refactoring

I reviewed the CI coverage and it is haphazard -- for example it was not clear were to add a test for #15124

Describe the solution you'd like

I would like CI coverage for all the feature flags in crates that datafusion users use

Describe alternatives you've considered

I suggest separate CI jobs for the different crates

crates:

  • datafusion-substrait
  • datafusion-proto
  • datafusion-functions
  • datafusion

For each of these crates, I would like a job that runs

  1. cargo check --no-default-features
  2. cargo check --no-default-features --features=<featurename>

Notes: this only runs cargo check (no need to actually create code)

Steps:

Additional context

No response

@blaginin
Copy link
Contributor

On a related note, maybe we want to reanimate codecov (#3679) and add a github action to prs? To ensure new code is covered

Image

@alamb
Copy link
Contributor Author

alamb commented Mar 11, 2025

On a related note, maybe we want to reanimate codecov (#3679) and add a github action to prs? To ensure new code is covered

That would be great if we could do so and prove that codecov actually provides useful coverage information. The last times I ran it (a while ago) it took a long time to run and gave very non-intuitive results

@blaginin
Copy link
Contributor

I'll play with it 🫡

@blaginin
Copy link
Contributor

WIP PoC is here. The way I think this should work is here: blaginin#4 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants