You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On a related note, maybe we want to reanimate codecov (#3679) and add a github action to prs? To ensure new code is covered
That would be great if we could do so and prove that codecov actually provides useful coverage information. The last times I ran it (a while ago) it took a long time to run and gave very non-intuitive results
Is your feature request related to a problem or challenge?
DataFusion has many rust features (e.g.
--features=parquet
) and recently we hit discovered several failures for features during refactoringI reviewed the CI coverage and it is haphazard -- for example it was not clear were to add a test for #15124
Describe the solution you'd like
I would like CI coverage for all the feature flags in crates that datafusion users use
Describe alternatives you've considered
I suggest separate CI jobs for the different crates
crates:
datafusion-substrait
datafusion-proto
datafusion-functions
datafusion
For each of these crates, I would like a job that runs
cargo check --no-default-features
cargo check --no-default-features --features=<featurename>
Notes: this only runs
cargo check
(no need to actually create code)Steps:
datafusion-substrait
anddatafusion-proto
CI feature checks, increase coverage #15156 (review)datafusion-functions
cratedatafusion
crateAdditional context
No response
The text was updated successfully, but these errors were encountered: