Skip to content

Some targets in the datafusion crate do not compile with default features #15208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alamb opened this issue Mar 13, 2025 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Mar 13, 2025

Describe the bug

Some targets in the datafusion crate do not compile with default features

Found while writing some tests

To Reproduce

cargo check --all-targets  --no-default-features -p datafusion

...
error[E0433]: failed to resolve: use of undeclared crate or module `parquet`
  --> datafusion/core/benches/sql_query_with_io.rs:39:5
   |
39 | use parquet::arrow::ArrowWriter;
   |     ^^^^^^^ use of undeclared crate or module `parquet`

error[E0432]: unresolved import `datafusion::datasource::file_format::parquet`
  --> datafusion/core/benches/sql_query_with_io.rs:26:22
   |
26 |         file_format::parquet::ParquetFormat,
   |                      ^^^^^^^ could not find `parquet` in `file_format`
   |
note: found an item that was configured out
  --> /Users/andrewlamb/Software/datafusion/datafusion/core/src/datasource/file_format/mod.rs:29:9
   |
29 | pub mod parquet;
   |         ^^^^^^^
note: the item is gated behind the `parquet` feature
  --> /Users/andrewlamb/Software/datafusion/datafusion/core/src/datasource/file_format/mod.rs:28:7
   |
28 | #[cfg(feature = "parquet")]
   |       ^^^^^^^^^^^^^^^^^^^

error[E0433]: failed to resolve: use of undeclared crate or module `datafusion_functions_nested`
  --> datafusion/core/tests/user_defined/user_defined_scalar_functions.rs:45:5
   |
45 | use datafusion_functions_nested::range::range_udf;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ use of undeclared crate or module `datafusion_functions_nested`
   |
help: there is a crate or module with a similar name
   |
45 | use datafusion_functions_table::range::range_udf;
   |     ~~~~~~~~~~~~~~~~~~~~~~~~~~

Expected behavior

I expect this command to succeed:

cargo check --all-targets  --no-default-features -p datafusion

Additional context

No response

@alamb alamb added the bug Something isn't working label Mar 13, 2025
@alamb
Copy link
Contributor Author

alamb commented Mar 13, 2025

Actually, I am not sure this is a bug, closing

@alamb alamb closed this as completed Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant