Skip to content

Cannot compile datafusion without feature regex_expressions #5621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Cheappie opened this issue Mar 16, 2023 · 2 comments
Closed

Cannot compile datafusion without feature regex_expressions #5621

Cheappie opened this issue Mar 16, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@Cheappie
Copy link
Contributor

Cheappie commented Mar 16, 2023 •
edited
Loading

Describe the bug
Cannot compile datafusion-physical-expr crate when regex_expressions feature is disabled.
This occurs on version 20.0.0.

To Reproduce
Disable default features, then try to build the project.

Expected behavior
If something is hidden behind feature flag, that means It's not required. Then It shouldn't stop project from building.
@Cheappie Cheappie added the bug Something isn't working label Mar 16, 2023
@alamb
Copy link
Contributor

alamb commented Mar 19, 2023

If something is hidden behind feature flag, that means It's not required. Then It shouldn't stop project from building.

I agree

I think I may have fixed this (by accident) in #5536 #5536 (comment)

However, I don't think there is CI coverage. It would be great to add coverage

@alamb
Copy link
Contributor

alamb commented Mar 11, 2025

Will bo covered by #15155

@alamb alamb closed this as completed Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alamb @Cheappie