Fix BenchReadThroughputLatency batch read can't stop problems. #4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horizonzy
commented
Feb 23, 2024
| @@ -89,7 +89,7 @@ private static void readLedger(ClientConfiguration conf, long ledgerId, byte[] p | |||
| lh = bk.openLedgerNoRecovery(ledgerId, BookKeeper.DigestType.CRC32, | |||
| passwd); | |||
| long lastConfirmed = Math.min(lh.getLastAddConfirmed(), absoluteLimit); | |||
| if (lastConfirmed == lastRead) { | |||
| if (lastConfirmed <= lastRead) { | |||
There was a problem hiding this comment.
if the read is batched, the lastRead may be greater than lastConfirmed.
| @@ -102,14 +102,14 @@ private static void readLedger(ClientConfiguration conf, long ledgerId, byte[] p | |||
| } | |||
| long starttime = System.nanoTime(); | |||
|
|
|||
| while (entriesRead <= lastConfirmed) { | |||
| while (entriesRead < lastConfirmed) { | |||
| long nextLimit = lastRead + 100000; | |||
| Enumeration<LedgerEntry> entries; | |||
| if (batchEntries <= 0) { | |||
| long readTo = Math.min(nextLimit, lastConfirmed); | |||
| entries = lh.readEntries(lastRead + 1, readTo); | |||
There was a problem hiding this comment.
If the read is single read, we should make sure that entriesRead is less than lastConfirmed. Or the lastRead + 1 will be greater than readTo.
| long nextLimit = lastRead + 100000; | ||
| Enumeration<LedgerEntry> entries; | ||
| if (batchEntries <= 0) { | ||
| long readTo = Math.min(nextLimit, lastConfirmed); | ||
| entries = lh.readEntries(lastRead + 1, readTo); | ||
| } else { | ||
| entries = lh.batchReadEntries(lastRead, batchEntries, -1); | ||
| entries = lh.batchReadEntries(lastRead + 1, batchEntries, -1); |
There was a problem hiding this comment.
The lastRead entry already be read, so we should read next entry at the next read.
There was a problem hiding this comment.
Do we need init the lastRead to -1 instead of 0, otherwise the entry 0 can't be read
hangc0276
reviewed
Feb 26, 2024
| while (entriesRead <= lastConfirmed) { | ||
| long nextLimit = lastRead + 100000; | ||
| while (entriesRead < lastConfirmed) { | ||
| long nextLimit = lastRead + 10; |
There was a problem hiding this comment.
Sorry, that's a test at my local, I will revert it.
horizonzy
commented
Feb 26, 2024
| @@ -89,7 +89,7 @@ private static void readLedger(ClientConfiguration conf, long ledgerId, byte[] p | |||
| lh = bk.openLedgerNoRecovery(ledgerId, BookKeeper.DigestType.CRC32, | |||
| passwd); | |||
| long lastConfirmed = Math.min(lh.getLastAddConfirmed(), absoluteLimit); | |||
| if (lastConfirmed == lastRead) { | |||
| if (lastConfirmed <= lastRead + 1) { | |||
There was a problem hiding this comment.
Because we from the entry 0 to start read, so here we should make lastRead + 1 to compare with lastConfirmed.
hangc0276
approved these changes
Mar 5, 2024
Ghatage
pushed a commit
to sijie/bookkeeper
that referenced
this pull request
Jul 12, 2024
…e#4220) Fix BenchReadThroughputLatency batch read can't stop problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix BenchReadThroughputLatency batch read can't stop problems.