Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4200: fix flaky test DeferredSyncTest.testForceWillAdvanceLacOnlyUpToLastAcknoledgedWrite #4234

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Issue 4200: fix flaky test DeferredSyncTest.testForceWillAdvanceLacOnlyUpToLastAcknoledgedWrite #4234

merged 2 commits into from
Mar 21, 2024

Conversation

tmzk1005
Copy link
Contributor

@tmzk1005 tmzk1005 commented Mar 20, 2024 •
edited
Loading

Motivation

fix #4200

DeferredSyncTest.testForceWillAdvanceLacOnlyUpToLastAcknoledgedWrite is flaky. The build times out since the test MAY never finishes. This PR fix it.

Changes

Use synchronized block to operate suspendedBookiesForForceLedgerAcks and deferredBookieForceLedgerResponses

Master Issue: #4200

@lhotari
Copy link
Member

lhotari commented Mar 21, 2024

@nicoloboschi @eolivelli Please review and merge since this fixes a problem that is very common in CI.
For example, it failed in this build very recently: https://github.com/apache/bookkeeper/actions/runs/8375785440/job/22934347745#step:11:419
The build will hang for 75 minutes when this happens. A timeout would also be great.

@nicoloboschi nicoloboschi merged commit 37708ad into apache:master Mar 21, 2024
20 checks passed
@nicoloboschi nicoloboschi added this to the 4.17.0 milestone Mar 21, 2024
nicoloboschi pushed a commit that referenced this pull request Mar 21, 2024
@tmzk1005 @nicoloboschi
Issue 4200: fix flaky test DeferredSyncTest.testForceWillAdvanceLacOn…
963a540 
…lyUpToLastAcknoledgedWrite (#4234)

* Issue 4200: fix flaky test DeferredSyncTest.testForceWillAdvanceLacOnlyUpToLastAcknoledgedWrite

* add a comment

(cherry picked from commit 37708ad)
@tmzk1005 tmzk1005 deleted the fix-4200-flaky-test branch March 21, 2024 16:36
eolivelli pushed a commit that referenced this pull request Mar 25, 2024
@tmzk1005 @eolivelli
Issue 4200: fix flaky test DeferredSyncTest.testForceWillAdvanceLacOn…
74c01cb 
…lyUpToLastAcknoledgedWrite (#4234)

* Issue 4200: fix flaky test DeferredSyncTest.testForceWillAdvanceLacOnlyUpToLastAcknoledgedWrite

* add a comment

(cherry picked from commit 37708ad)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
@tmzk1005
Issue 4200: fix flaky test DeferredSyncTest.testForceWillAdvanceLacOn…
ea904b3 
…lyUpToLastAcknoledgedWrite (apache#4234)

* Issue 4200: fix flaky test DeferredSyncTest.testForceWillAdvanceLacOnlyUpToLastAcknoledgedWrite

* add a comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@lhotari lhotari lhotari approved these changes

Assignees
No one assigned
Labels
cherry-picked/branch-4.16 release/4.16.5
Projects
None yet
Milestone
4.17.0
Development

Successfully merging this pull request may close these issues.

Flaky-test: DeferredSyncTest.testForceWillAdvanceLacOnlyUpToLastAcknoledgedWrite
3 participants
@tmzk1005 @lhotari @nicoloboschi