-
Notifications
You must be signed in to change notification settings - Fork 918
Verify footer tags when reading encrypted Parquet files with plaintext footers #7459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify footer tags when reading encrypted Parquet files with plaintext footers #7459
Conversation
e7cef64
to
2ee3c82
Compare
7d6d3f7
to
e15517f
Compare
e15517f
to
a00efec
Compare
@adamreeve I've addressed your feedback, do you think this is ready for a final pass by @alamb ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking pretty good to me although I've got one further comment.
Co-authored-by: Adam Reeve <[email protected]>
87097f5
to
e87ccff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks Rok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me -- thank you @rok and @adamreeve
Which issue does this PR close?
From #7255
Closes #7255.
Rationale for this change
This adds a mechanism that willl prevent tampering with metadata.
What changes are included in this PR?
This adds a read-time integrity verification of footer metadata of read file.
Are there any user-facing changes?
Users get an opaque integrity verification check by default (will throw if failed) and can choose to opt out by calling
FileDecryptionProperties::Builder::disable_footer_signature_verification
method.