Review feedback

Author: rok

parquet/src/encryption/ciphers.rs

@@ -30,7 +30,7 @@ pub(crate) const SIZE_LEN: usize = 4;
 pub(crate) trait BlockDecryptor: Debug + Send + Sync {
     fn decrypt(&self, length_and_ciphertext: &[u8], aad: &[u8]) -> Result<Vec<u8>>;
 
-    fn compute_plaintext_tag(&self, aad: &[u8], plaintext: &mut [u8]) -> Result<Vec<u8>>;
+    fn compute_plaintext_tag(&self, aad: &[u8], plaintext: &[u8]) -> Result<Vec<u8>>;
 }
 
 #[derive(Debug, Clone)]
@@ -66,7 +66,8 @@ impl BlockDecryptor for RingGcmBlockDecryptor {
         Ok(result)
     }
 
-    fn compute_plaintext_tag(&self, aad: &[u8], plaintext: &mut [u8]) -> Result<Vec<u8>> {
+    fn compute_plaintext_tag(&self, aad: &[u8], plaintext: &[u8]) -> Result<Vec<u8>> {
+        let mut plaintext = plaintext.to_vec();
         let nonce = &plaintext[plaintext.len() - NONCE_LEN - TAG_LEN..plaintext.len() - TAG_LEN];
         let nonce = ring::aead::Nonce::try_assume_unique_for_key(nonce)?;
         let plaintext_end = plaintext.len() - NONCE_LEN - TAG_LEN;

parquet/src/encryption/decrypt.rs

@@ -558,10 +558,10 @@ impl FileDecryptor {
     /// Verify the signature of the footer
     pub(crate) fn verify_plaintext_footer_signature(
         &self,
-        plaintext_footer: &mut [u8],
+        plaintext_footer: &[u8],
     ) -> Result<()> {
         // Plaintext footer format is: [plaintext metadata, nonce, authentication tag]
-        let tag = plaintext_footer[plaintext_footer.len() - TAG_LEN..].to_vec();
+        let tag = &plaintext_footer[plaintext_footer.len() - TAG_LEN..];
         let aad = create_footer_aad(self.file_aad())?;
         let footer_decryptor = self.get_footer_decryptor()?;
 

parquet/src/file/metadata/reader.rs

@@ -972,7 +972,7 @@ impl ParquetMetaDataReader {
                 file_decryption_properties,
             )?;
             if file_decryption_properties.check_plaintext_footer_integrity() && !encrypted_footer {
-                file_decryptor_value.verify_plaintext_footer_signature(buf.to_vec().as_mut())?;
+                file_decryptor_value.verify_plaintext_footer_signature(buf)?;
             }
             file_decryptor = Some(file_decryptor_value);
         }